fix: wallets data dates consistency causing crashes in Safari #12593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhsz
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
review needed 👀
tooling 🔧
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nhsz
changed the title
wackerow
requested changes
Mar 27, 2024
Comment on lines
51
to
57
| - type: input | ||
| id: wallet_live_date | ||
| attributes: | ||
| label: When did the wallet go live to users? | ||
| description: Please provide a date when the wallet was usable by the public | ||
| validations: | ||
| required: true |
There was a problem hiding this comment.
@nhsz I think we still need this as part of the initial issue request... Our listing policy requires the product be live for 6 months, and this would be how we check that.
Shouldn't have any impact on the other changes
corwintines
requested changes
Mar 27, 2024
Comment on lines
51
to
57
| - type: input | ||
| id: wallet_live_date | ||
| attributes: | ||
| label: When did the wallet go live to users? | ||
| description: Please provide a date when the wallet was usable by the public | ||
| validations: | ||
| required: true |
There was a problem hiding this comment.
I would add this back in.
I think we need it given listing policy requires 6 months. While we might not need it in the actual wallet data file, its good information to have in the issues being filed.
wackerow
approved these changes
Mar 27, 2024
corwintines
approved these changes
Mar 27, 2024
This was referenced Mar 27, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wallets data inconsistencies related to dates formatting that are causing crashes in Safari when opening the
MoreInfosectionDescription
last_updatedformat inconsistency where neededwallet_live_datewallet data prop that also has inconsistent formattingFixes #12590