Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallets data dates consistency causing crashes in Safari #12593

Merged
merged 5 commits into from
Mar 27, 2024
Merged

fix: wallets data dates consistency causing crashes in Safari #12593

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d1df4e
chore: remove unused prop
nhsz Mar 27, 2024
7f0b1a3
fix: consistent format of prop
nhsz Mar 27, 2024
feeb1cb
chore: restore wallet_live_date on gh template
nhsz Mar 27, 2024
2e4c053
chore: remove extra spacing
nhsz Mar 27, 2024
6aa96c1
Merge branch 'staging' into fix-wallets-data-dates-consistency
corwintines Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/suggest_wallet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ body:
description: Please provide a URL (e.g. to the website of the wallet).
validations:
required: true
- type: input
id: wallet_live_date
attributes:
label: When did the wallet go live to users?
description: Please provide a date when the wallet was usable by the public
validations:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhsz I think we still need this as part of the initial issue request... Our listing policy requires the product be live for 6 months, and this would be how we check that.

Shouldn't have any impact on the other changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add this back in.

I think we need it given listing policy requires 6 months. While we might not need it in the actual wallet data file, its good information to have in the issues being filed.

- type: input
id: wallet_active_development_team
attributes:
Expand Down
52 changes: 7 additions & 45 deletions src/data/wallets/wallet-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export const walletsData: WalletData[] = [
image: KeystoneImage,
brand_color: "#ffffff",
url: "https://keyst.one/",
wallet_live_date: "Dec 2018",
active_development_team: true,
languages_supported: ["en", "zh", "es", "ko"],
twitter: "https://twitter.com/KeystoneWallet",
Expand Down Expand Up @@ -92,7 +91,6 @@ export const walletsData: WalletData[] = [
image: Coin98Image,
brand_color: "#ffffff",
url: "https://coin98.com/wallet",
wallet_live_date: "2018",
active_development_team: true,
languages_supported: [
"vi",
Expand Down Expand Up @@ -148,7 +146,6 @@ export const walletsData: WalletData[] = [
image: LoopringImage,
brand_color: "#ffffff",
url: "https://loopring.io/#/wallet",
wallet_live_date: "Nov 25, 2020",
active_development_team: true,
languages_supported: ["en", "zh"],
twitter: "https://twitter.com/loopringorg",
Expand Down Expand Up @@ -190,12 +187,11 @@ export const walletsData: WalletData[] = [
documentation: "",
},
{
last_updated: "March 7, 2024",
last_updated: "2024-03-07",
name: "Argent",
image: ArgentImage,
brand_color: "#ffffff",
url: "https://www.argent.xyz/",
wallet_live_date: "2018",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/argenthq",
Expand Down Expand Up @@ -241,7 +237,6 @@ export const walletsData: WalletData[] = [
image: CoinbaseImage,
brand_color: "#0052FF",
url: "https://www.coinbase.com/wallet",
wallet_live_date: "2018",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -298,7 +293,6 @@ export const walletsData: WalletData[] = [
image: FrameImage,
brand_color: "#222021",
url: "https://frame.sh",
wallet_live_date: "April 2019",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/0xFrame",
Expand Down Expand Up @@ -342,7 +336,6 @@ export const walletsData: WalletData[] = [
image: MetaMaskImage,
brand_color: "#ffffff",
url: "https://metamask.io",
wallet_live_date: "2016",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -436,7 +429,6 @@ export const walletsData: WalletData[] = [
image: SafeImage,
brand_color: "#12ff80",
url: "https://safe.global/",
wallet_live_date: "2017",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/safe",
Expand Down Expand Up @@ -474,12 +466,11 @@ export const walletsData: WalletData[] = [
documentation: "https://docs.safe.global/",
},
{
last_updated: "August 23, 2023",
last_updated: "2023-08-23",
name: "Ambire",
image: AmbireImage,
brand_color: "#aa6aff",
url: "https://www.ambire.com",
wallet_live_date: "December 2021",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/AmbireWallet",
Expand Down Expand Up @@ -518,12 +509,11 @@ export const walletsData: WalletData[] = [
documentation: "",
},
{
last_updated: "June 24, 2022",
last_updated: "2022-06-24",
name: "imToken",
image: imTokenImage,
brand_color: "#098de6",
url: "https://token.im/",
wallet_live_date: "2016",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -577,7 +567,6 @@ export const walletsData: WalletData[] = [
image: OneInchWalletImage,
brand_color: "#082D6E",
url: "https://1inch.io/",
wallet_live_date: "2022-04-27",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -634,7 +623,6 @@ export const walletsData: WalletData[] = [
image: FoxWalletImage,
brand_color: "#ffffff",
url: "https://foxwallet.com/en",
wallet_live_date: "November, 2021",
active_development_team: true,
languages_supported: ["en", "zh", "uk", "ru", "es", "id"],
twitter: "https://twitter.com/FoxWallet",
Expand Down Expand Up @@ -677,7 +665,6 @@ export const walletsData: WalletData[] = [
image: PillarImage,
brand_color: "#7501D9",
url: "https://www.pillar.fi/",
wallet_live_date: "December 18 2018 V1, June 2020 V2",
active_development_team: true,
languages_supported: ["en", "et", "bs", "zh"],
twitter: "https://twitter.com/PillarWallet",
Expand Down Expand Up @@ -723,7 +710,6 @@ export const walletsData: WalletData[] = [
image: MewImage,
brand_color: "#05C0A5",
url: "https://www.mewwallet.com",
wallet_live_date: "13 March 2020",
active_development_team: true,
languages_supported: ["en", "ru", "zh"],
twitter: "https://twitter.com/myetherwallet",
Expand Down Expand Up @@ -768,7 +754,6 @@ export const walletsData: WalletData[] = [
image: UnstoppableWalletImage,
brand_color: "#ffbe43",
url: "https://unstoppable.money/",
wallet_live_date: "2017",
active_development_team: true,
languages_supported: ["en", "fr", "de", "ko", "ru", "zh", "es", "tr"],
twitter: "https://twitter.com/unstoppablebyhs",
Expand Down Expand Up @@ -812,7 +797,6 @@ export const walletsData: WalletData[] = [
image: MyEtherWalletImage,
brand_color: "#ffffff",
url: "https://www.myetherwallet.com/",
wallet_live_date: "August 2015",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/myetherwallet",
Expand Down Expand Up @@ -856,7 +840,6 @@ export const walletsData: WalletData[] = [
image: AlphaWalletImage,
brand_color: "#ffffff",
url: "https://alphawallet.com/",
wallet_live_date: "2018",
active_development_team: true,
languages_supported: ["en", "zh", "es", "fr", "vi"],
twitter: "https://twitter.com/alphawallet",
Expand Down Expand Up @@ -895,12 +878,11 @@ export const walletsData: WalletData[] = [
documentation: "",
},
{
last_updated: "June 24, 2022",
last_updated: "2022-06-24",
name: "Bridge wallet",
image: BridgeWalletImage,
brand_color: "#ffffff",
url: "https://www.mtpelerin.com/bridge-wallet",
wallet_live_date: "April 2020",
active_development_team: true,
languages_supported: ["en", "fr", "de", "it", "es", "zh", "zh-tw"],
twitter: "https://twitter.com/mtpelerin",
Expand Down Expand Up @@ -939,12 +921,11 @@ export const walletsData: WalletData[] = [
documentation: "",
},
{
last_updated: "2022-9-14",
last_updated: "2022-09-14",
name: "Torus Wallet",
image: TorusImage,
brand_color: "#0364ff",
url: "https://app.tor.us",
wallet_live_date: "May 2019",
active_development_team: true,
languages_supported: ["en", "de", "ja", "ko", "zh", "es"],
twitter: "https://twitter.com/web3auth",
Expand Down Expand Up @@ -984,12 +965,11 @@ export const walletsData: WalletData[] = [
mpc: true,
},
{
last_updated: "2022-7-18",
last_updated: "2022-07-18",
name: "TokenPocket",
image: TokenPocketImage,
brand_color: "#2980fe",
url: "https://www.tokenpocket.pro/",
wallet_live_date: "April, 2018",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1051,12 +1031,11 @@ export const walletsData: WalletData[] = [
documentation: "https://help.tokenpocket.pro/developer-en/",
},
{
last_updated: "2022-6-30",
last_updated: "2022-06-30",
name: "Rainbow",
image: RainbowImage,
brand_color: "#001A4D",
url: "https://rainbow.me",
wallet_live_date: "June 2019",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1114,7 +1093,6 @@ export const walletsData: WalletData[] = [
image: TrezorImage,
brand_color: "#ffffff",
url: "https://trezor.io/",
wallet_live_date: "2012-12-31",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/Trezor",
Expand Down Expand Up @@ -1158,7 +1136,6 @@ export const walletsData: WalletData[] = [
image: LedgerImage,
brand_color: "#fb5e01",
url: "https://www.ledger.com/",
wallet_live_date: "2014-12-31",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1214,7 +1191,6 @@ export const walletsData: WalletData[] = [
image: InfinityWalletImage,
brand_color: "#137dc7",
url: "https://infinitywallet.io/",
wallet_live_date: "2019-11-01",
active_development_team: true,
languages_supported: ["en", "es"],
twitter: "https://twitter.com/InfinityWallet",
Expand Down Expand Up @@ -1258,7 +1234,6 @@ export const walletsData: WalletData[] = [
image: ExodusImage,
brand_color: "#1F2033",
url: "https://exodus.com",
wallet_live_date: "2015-12-31",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/exodus_io",
Expand Down Expand Up @@ -1308,7 +1283,6 @@ export const walletsData: WalletData[] = [
image: RabbyWalletImage,
brand_color: "#FFFFFF",
url: "https://rabby.io",
wallet_live_date: "2021-07-27",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/Rabby_io",
Expand Down Expand Up @@ -1354,7 +1328,6 @@ export const walletsData: WalletData[] = [
image: ZerionImage,
brand_color: "#2962EF",
url: "https://zerion.io/",
wallet_live_date: "2022-05-26",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1414,7 +1387,6 @@ export const walletsData: WalletData[] = [
image: EnkryptImage,
brand_color: "#ffffff",
url: "https://www.enkrypt.com",
wallet_live_date: "2022-08-03",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/enkrypt",
Expand Down Expand Up @@ -1458,7 +1430,6 @@ export const walletsData: WalletData[] = [
image: GridPlusImage,
brand_color: "#ffffff",
url: "https://gridplus.io/",
wallet_live_date: "2020-10-01",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/gridplus",
Expand Down Expand Up @@ -1502,7 +1473,6 @@ export const walletsData: WalletData[] = [
image: BitkeepImage,
brand_color: "#ffffff",
url: "https://www.bitkeep.com/",
wallet_live_date: "2018-07-01",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/BitKeepOS",
Expand Down Expand Up @@ -1546,7 +1516,6 @@ export const walletsData: WalletData[] = [
image: BlockWalletImage,
brand_color: "#52C200",
url: "https://blockwallet.io",
wallet_live_date: "2022-02-28",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://x.com/GetBlockWallet",
Expand Down Expand Up @@ -1596,7 +1565,6 @@ export const walletsData: WalletData[] = [
image: OneKeyImage,
brand_color: "#00B812",
url: "https://onekey.so/",
wallet_live_date: "2022-07-31",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1661,7 +1629,6 @@ export const walletsData: WalletData[] = [
image: ApexImage,
brand_color: "CF9500",
url: "https://apexwallet.xyz/",
wallet_live_date: "2022-08-31",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/ApexWallet",
Expand Down Expand Up @@ -1705,7 +1672,6 @@ export const walletsData: WalletData[] = [
image: TahoImage,
brand_color: "#FDAE49",
url: "https://taho.xyz",
wallet_live_date: "2021-12-20",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/taho_xyz",
Expand Down Expand Up @@ -1754,7 +1720,6 @@ export const walletsData: WalletData[] = [
image: PhantomImage,
brand_color: "#AB9FF2",
url: "https://phantom.app/",
wallet_live_date: "2021-05-17",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1830,7 +1795,6 @@ export const walletsData: WalletData[] = [
image: XDEFIImage,
brand_color: "#2041E0",
url: "https://www.xdefi.io",
wallet_live_date: "2021-10-12",
active_development_team: true,
languages_supported: ["en", "fr", "de", "ru"],
twitter: "https://twitter.com/xdefi_wallet",
Expand Down Expand Up @@ -1877,7 +1841,6 @@ export const walletsData: WalletData[] = [
image: TrustWalletImage,
brand_color: "#0500FF",
url: "https://www.trustwallet.com/",
wallet_live_date: "2017-10-25",
active_development_team: true,
languages_supported: [
"en",
Expand Down Expand Up @@ -1941,7 +1904,6 @@ export const walletsData: WalletData[] = [
image: AuroxImage,
brand_color: "#1F47FF",
url: "https://getaurox.com/wallet",
wallet_live_date: "2022-12-06",
active_development_team: true,
languages_supported: ["en"],
twitter: "https://twitter.com/getaurox",
Expand Down
1 change: 0 additions & 1 deletion src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,6 @@ export interface WalletData {
image: StaticImageData
brand_color: string
url: string
wallet_live_date: string
active_development_team: boolean
languages_supported: string[]
twitter: string
Expand Down
Loading