refactor(theme/typography): update typography with DS #12853

TylerAPfledderer · 2024-04-28T01:30:41Z

Description

Update typography theme configuration to be in sync with the latest DS updates in Figma

netlify · 2024-04-28T01:30:57Z

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	`a29b281`
🔍 Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/663b90f6e5e35d0008be9c06
😎 Deploy Preview	https://deploy-preview-12853--ethereumorg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 30 (🔴 down 9 from production) Accessibility: 93 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

…sizes

minimalsm · 2024-05-01T08:44:49Z

@coderabbitai review

coderabbitai · 2024-05-01T08:44:58Z

Warning

Rate Limit Exceeded

@minimalsm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 27 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 6a8dde0 and ed076d2.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

TylerAPfledderer · 2024-05-01T13:09:06Z

@TylerAPfledderer needs to review Figma threads for additional changes or reversions

TylerAPfledderer · 2024-05-01T16:16:38Z

@pettinarip if you are good here, would like to go ahead and have @nloureiro double-check these.

pettinarip · 2024-05-02T08:03:39Z

@pettinarip if you are good here, would like to go ahead and have @nloureiro double-check these.

UI Review Changeset

Preview Heading component story

Preview Text component stories

Interesting. Didn't know that there were these many differences xD

Sure. I'll review this later today. Thanks for the PR

nloureiro · 2024-05-02T10:05:57Z

@TylerAPfledderer I can´t really tell about the code changes, but I did a run on the dev preview, and everything seems in place! I only found one issue.

Other than that, LFG!!! Thank you!

only issue: this fake h1 should be 1rem and not 1.25.

TylerAPfledderer · 2024-05-03T04:44:47Z

@nloureiro that adjustment has been made

nloureiro · 2024-05-03T08:11:36Z

@nloureiro that adjustment has been made

awesome! Thank you!

pettinarip

@TylerAPfledderer looks good on my side. Big impact going on in this PR.

Left a question about an extra heading size, I would like to have consistency with the figma file if possible.

pettinarip · 2024-05-08T08:42:01Z

src/@chakra-ui/components/Heading.ts

-  {
-    ...defaultSizes,
+const fontSizeScale: SIZE_SCALE = {
+  "3xl": ["5xl", null, null, "6xl"],


This size is not documented in the figma file, right?

We have 7 sizes in the code but 6 in figma. Should we have this size in the code? maybe not. cc @nloureiro

Whoops! No that should not be there. I'll have it removed.

@pettinarip this is now updated, removing the 3xl token completely.

pettinarip · 2024-05-08T08:43:32Z

src/@chakra-ui/styles.ts

@@ -12,7 +12,7 @@ const styles = {
    body: {
      bg: "background.base",
      lineHeight: "base",
-      fontSize: "md",
+      fontSize: ["sm", null, null, "md"],


wooha! big change going on here 🚀

github-actions bot added the needs review 👀 label Apr 28, 2024

refactor(Heading): update heading theme configuration

a43e49d

TylerAPfledderer force-pushed the refactor/typography-DS-update branch from ea5c38a to a43e49d Compare April 28, 2024 01:42

TylerAPfledderer added 8 commits April 28, 2024 12:11

refactor(theme/Heading): update line heights

3e14d55

chore: set story modes for Heading and Text

4902a31

chore(.storybook/preview): convert incoming viewport vals to em

f591e3b

refactor: show story mode for md instead of sm for Text and Heading

aae5a2b

refactor(theme/styles): set responsize font size for body copy

55af128

chore(Text.stories): apply story modes only to body copy

437d345

refactor(theme/Heading): adjust md font size

b6265b9

refactor(theme/Heading) adjust line height for 2xl, lg, and md …

ed076d2

…sizes

TylerAPfledderer marked this pull request as ready for review April 30, 2024 16:39

TylerAPfledderer requested review from wackerow, corwintines, pettinarip, minimalsm and nhsz as code owners April 30, 2024 16:39

TylerAPfledderer mentioned this pull request May 1, 2024

refactor(Hero): sync styles to latest DS #12875

Merged

TylerAPfledderer added 3 commits May 1, 2024 11:28

chore(Text.stories): disable story controls

21e01de

refactor: sync typography to newest DS updates

d15cfe1

refactor(Heading.stories): update visual text content

e14e6e7

style(HubHero): reformat small title size

96f63de

nloureiro approved these changes May 3, 2024

View reviewed changes

wackerow approved these changes May 7, 2024

View reviewed changes

wackerow assigned pettinarip May 7, 2024

pettinarip approved these changes May 8, 2024

View reviewed changes

TylerAPfledderer added 3 commits May 8, 2024 10:18

refactor(theme/Heading): remove 3xl token for sizes

1b6517e

refactor(Heading.stories): remove 3xl token from story

c7bd82f

fix(Heading.stories): create explicit display of h2 heading label

a29b281

pettinarip merged commit b86bef4 into ethereum:dev May 8, 2024
10 checks passed

TylerAPfledderer deleted the refactor/typography-DS-update branch May 8, 2024 20:46

This was referenced May 22, 2024

Release candidate: v8.6.0 #13016

Merged

Deploy v8.6.0 #13019

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(theme/typography): update typography with DS #12853

refactor(theme/typography): update typography with DS #12853

TylerAPfledderer commented Apr 28, 2024 •

edited

Loading

netlify bot commented Apr 28, 2024 •

edited

Loading

minimalsm commented May 1, 2024

coderabbitai bot commented May 1, 2024

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

TylerAPfledderer commented May 1, 2024 •

edited

Loading

TylerAPfledderer commented May 1, 2024

pettinarip commented May 2, 2024

nloureiro commented May 2, 2024

TylerAPfledderer commented May 3, 2024

nloureiro commented May 3, 2024

pettinarip left a comment

pettinarip May 8, 2024

TylerAPfledderer May 8, 2024

TylerAPfledderer May 8, 2024

pettinarip May 8, 2024

refactor(theme/typography): update typography with DS #12853

refactor(theme/typography): update typography with DS #12853

Conversation

TylerAPfledderer commented Apr 28, 2024 • edited Loading

Description

netlify bot commented Apr 28, 2024 • edited Loading

✅ Deploy Preview for ethereumorg ready!

minimalsm commented May 1, 2024

coderabbitai bot commented May 1, 2024

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

TylerAPfledderer commented May 1, 2024 • edited Loading

TylerAPfledderer commented May 1, 2024

pettinarip commented May 2, 2024

nloureiro commented May 2, 2024

TylerAPfledderer commented May 3, 2024

nloureiro commented May 3, 2024

pettinarip left a comment

Choose a reason for hiding this comment

pettinarip May 8, 2024

Choose a reason for hiding this comment

TylerAPfledderer May 8, 2024

Choose a reason for hiding this comment

TylerAPfledderer May 8, 2024

Choose a reason for hiding this comment

pettinarip May 8, 2024

Choose a reason for hiding this comment

TylerAPfledderer commented Apr 28, 2024 •

edited

Loading

netlify bot commented Apr 28, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

TylerAPfledderer commented May 1, 2024 •

edited

Loading