refactor(Hero): sync styles to latest DS #12875

TylerAPfledderer · 2024-04-30T23:22:57Z

Updates the Hero components so they match the latest DS changes.

Depends on #12853 to complete the sync

Summary by CodeRabbit

New Features
- Enhanced internationalization support in the ContentHero component for better translation handling.
- Improved responsive layout for the ContentHero and HomeHero components to adapt better on different screen sizes.
- Refined layout and button arrangement in the HubHero component for improved user interaction.
Refactor
- Updated component structures in ContentHero, HomeHero, and HubHero for enhanced responsiveness and maintainability.
Style
- Adjusted visual properties such as height and spacing in the HomeHero component to improve visual appeal on various devices.

netlify · 2024-04-30T23:23:13Z

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	`860e72a`
🔍 Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/6678899340870b00096bdd3d
😎 Deploy Preview	https://deploy-preview-12875--ethereumorg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	7 paths audited Performance: 42 (🔴 down 5 from production) Accessibility: 92 (no change from production) Best Practices: 83 (🔴 down 9 from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

TylerAPfledderer · 2024-04-30T23:25:10Z

src/components/Hero/ContentHero/ContentHero.stories.tsx

+  parameters: {
+    // Set asPath in mock router so the Breadcrums component can render
+    // the "home" text with correct translation
+    nextjs: {
+      router: {
+        asPath: "/en",
+      },
+    },
+  },


A good to know here, as this is integrated into Storybook with NextJS.

https://storybook.js.org/blog/integrate-nextjs-and-storybook-automatically/#nextrouter

Aha! interesting. Thanks

TylerAPfledderer · 2024-04-30T23:25:44Z

src/components/Hero/ContentHero/ContentHero.stories.tsx

  render: () => {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
-    const { t } = useTranslation("page-learn")
+    const { t } = getI18n()


Using this method is better here, so there are no errors/warnings of a hook being used outside of a component.

Though you have to specify the namespace when calling t on each instance, unless you make a middleman function.

minimalsm · 2024-05-01T08:43:54Z

@coderabbitai review

coderabbitai · 2024-05-01T08:44:02Z

Walkthrough

This update involves significant changes across various hero components, focusing on improving responsiveness and language translation handling. The alterations include switching from horizontal to vertical stacking in response to screen size, updating translation management from useTranslation to getI18n, and refining UI elements like spacing and heights for better visual adaptation across devices.

Changes

File Path	Summary of Changes
`.../ContentHero/ContentHero.stories.tsx`	Replaced `useTranslation` with `getI18n` for improved translation handling.
`.../ContentHero/index.tsx` `.../HubHero/index.tsx`	Replaced `HStack` with `Stack`, modifying direction and properties based on screen size to enhance responsiveness.
`.../HomeHero/index.tsx`	Adjusted UI properties such as the height of `Box` and spacing in `VStack`, and removed size attribute from `Text` for better visual adaptation on different screen resolutions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

TylerAPfledderer · 2024-05-01T13:07:05Z

@TylerAPfledderer needs to review this thread for additional changes.

https://www.figma.com/file/L3EE4KGFU9hXqKITYH7uTI#788888481

wackerow · 2024-05-07T22:15:14Z

Thanks @TylerAPfledderer! Looks good at first glance, assigning to @nloureiro for design eyes

pettinarip

Nice @TylerAPfledderer. Left a few questions but its looking good.

pettinarip · 2024-05-31T17:27:39Z

src/components/Hero/ContentHero/ContentHero.stories.tsx

+  parameters: {
+    // Set asPath in mock router so the Breadcrums component can render
+    // the "home" text with correct translation
+    nextjs: {
+      router: {
+        asPath: "/en",
+      },
+    },
+  },


Aha! interesting. Thanks

src/components/Hero/HomeHero/index.tsx

src/components/Hero/HubHero/index.tsx

wackerow · 2024-06-17T23:32:53Z

Looking great! I see one conflict, and some resolved conversations after the last review... @TylerAPfledderer If you get a chance to clear the conflicts, and @pettinarip if things look good I'd say go ahead and pull in

pettinarip

Nice job @TylerAPfledderer

TylerAPfledderer requested review from wackerow, corwintines, pettinarip, minimalsm and nhsz as code owners April 30, 2024 23:22

github-actions bot added the needs review 👀 label Apr 30, 2024

TylerAPfledderer commented Apr 30, 2024

View reviewed changes

TylerAPfledderer force-pushed the refactor/update-hero-ds branch from d829ccd to f30f775 Compare April 30, 2024 23:30

refactor(Hero): sync styles to latest DS

f30f775

TylerAPfledderer added 2 commits May 1, 2024 19:46

style(HubHero): add spacing to content at small viewports

4b22282

Merge remote-tracking branch 'origin/dev' into refactor/update-hero-ds

03c6333

TylerAPfledderer force-pushed the refactor/update-hero-ds branch from 6954446 to 03c6333 Compare May 3, 2024 04:34

wackerow assigned nloureiro May 7, 2024

wackerow requested a review from nloureiro May 7, 2024 22:15

wackerow added the needs design approval 🧑‍🎨 Approval from a designer is needed before merging label May 7, 2024

TylerAPfledderer added 3 commits May 8, 2024 18:04

Merge remote-tracking branch 'origin/dev' into refactor/update-hero-ds

115890d

Merge remote-tracking branch 'origin/dev' into refactor/update-hero-ds

7ea5c32

Merge remote-tracking branch 'origin/dev' into refactor/update-hero-ds

267f935

wackerow removed the needs review 👀 label May 22, 2024

pettinarip requested changes May 31, 2024

View reviewed changes

TylerAPfledderer added 2 commits June 1, 2024 01:09

fix(HomeHero): reset size prop for description text

36900f0

Merge remote-tracking branch 'upstream/dev' into refactor/update-hero-ds

ed2310f

Merge remote-tracking branch 'origin/dev' into refactor/update-hero-ds

cc68319

chore(ContentHero): remove unused import

860e72a

wackerow requested a review from pettinarip June 25, 2024 02:37

pettinarip approved these changes Jun 25, 2024

View reviewed changes

pettinarip merged commit 3d72912 into ethereum:dev Jun 25, 2024
10 checks passed

TylerAPfledderer deleted the refactor/update-hero-ds branch June 25, 2024 13:03

This was referenced Jul 10, 2024

Release candidate 8.7.1 #13366

Merged

Deploy v8.7.1 #13368

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(Hero): sync styles to latest DS #12875

refactor(Hero): sync styles to latest DS #12875

TylerAPfledderer commented Apr 30, 2024 •

edited by coderabbitai bot

Loading

netlify bot commented Apr 30, 2024 •

edited

Loading

TylerAPfledderer Apr 30, 2024

pettinarip May 31, 2024

TylerAPfledderer Apr 30, 2024 •

edited

Loading

minimalsm commented May 1, 2024

coderabbitai bot commented May 1, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

TylerAPfledderer commented May 1, 2024 •

edited

Loading

wackerow commented May 7, 2024

pettinarip left a comment

pettinarip May 31, 2024

wackerow commented Jun 17, 2024

pettinarip left a comment

refactor(Hero): sync styles to latest DS #12875

refactor(Hero): sync styles to latest DS #12875

Conversation

TylerAPfledderer commented Apr 30, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

netlify bot commented Apr 30, 2024 • edited Loading

✅ Deploy Preview for ethereumorg ready!

TylerAPfledderer Apr 30, 2024

Choose a reason for hiding this comment

pettinarip May 31, 2024

Choose a reason for hiding this comment

TylerAPfledderer Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

minimalsm commented May 1, 2024

coderabbitai bot commented May 1, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

TylerAPfledderer commented May 1, 2024 • edited Loading

wackerow commented May 7, 2024

pettinarip left a comment

Choose a reason for hiding this comment

pettinarip May 31, 2024

Choose a reason for hiding this comment

wackerow commented Jun 17, 2024

pettinarip left a comment

Choose a reason for hiding this comment

TylerAPfledderer commented Apr 30, 2024 •

edited by coderabbitai bot

Loading

netlify bot commented Apr 30, 2024 •

edited

Loading

TylerAPfledderer Apr 30, 2024 •

edited

Loading

coderabbitai bot commented May 1, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

TylerAPfledderer commented May 1, 2024 •

edited

Loading