Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wallet data and elements from /wallets/ page #7185

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

corwintines
Copy link
Member

Description

  • Remove the "Get a wallet" section from /wallets/ and just leave CTA to find wallets page
  • Remove unused code after removing crypto curious and crypto converted cards
  • Remove wallet CSV import
  • Remove unused translations in page-wallets.json

Before:
ethereum org_en_wallets_

After:
localhost_8000_en_wallets_

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Jul 26, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 26, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea: rather than remove this, could we repurpose it using the ranking algorithm to show the 'top' wallets?

I've not any context on the conversations around removing this, so just a thought 😀.

@corwintines
Copy link
Member Author

I think im just in favor of removing it in general and getting people to use the find wallets page. But open to other opinions on this one.

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed offline & agreed on this route - let's stick with this approach, which simplifies this page & pushes users to the /find-wallet page if they want to view wallet options.

@samajammin samajammin merged commit fba24b0 into dev Aug 2, 2022
@samajammin samajammin deleted the remove-wallet-data-wallets-page branch August 2, 2022 03:24
@Nana12345678910
Copy link

Nana12345678910 commented Aug 2, 2022 via email

@corwintines corwintines mentioned this pull request Aug 4, 2022
@corwintines corwintines mentioned this pull request Oct 19, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants