-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wallet data and elements from /wallets/ page #7185
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 29m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea: rather than remove this, could we repurpose it using the ranking algorithm to show the 'top' wallets?
I've not any context on the conversations around removing this, so just a thought 😀.
I think im just in favor of removing it in general and getting people to use the find wallets page. But open to other opinions on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed offline & agreed on this route - let's stick with this approach, which simplifies this page & pushes users to the /find-wallet page if they want to view wallet options.
On Tue, 26 Jul 2565 BE at 10:04 am, Corwin Smith ***@***.***> wrote:
Description
- Remove the "Get a wallet" section from /wallets/ and just leave CTA
to find wallets page
- Remove unused code after removing crypto curious and crypto
converted cards
- Remove wallet CSV import
- Remove unused translations in page-wallets.json
Before:
[image: ethereum org_en_wallets_]
<https://user-images.githubusercontent.com/15589226/180894875-b5e2f1d4-0bd7-4204-b222-ee6c67cdde9a.png>
After:
[image: localhost_8000_en_wallets_]
<https://user-images.githubusercontent.com/15589226/180894889-36c2ab9a-338e-48fa-8a92-f08edc01eea2.png>
------------------------------
You can view, comment on, or merge this pull request online at:
#7185
Commit Summary
- ef9d8ac
<ef9d8ac>
remove wallet data and elements from /wallets/ page
File Changes
(2 files
<https://github.com/ethereum/ethereum-org-website/pull/7185/files>)
- *M* src/intl/en/page-wallets.json
<https://github.com/ethereum/ethereum-org-website/pull/7185/files#diff-191ce9f858bded2249977f01831f347d18afdf518a449d9a07f8c9b10f96641b>
(9)
- *M* src/pages-conditional/wallets.tsx
<https://github.com/ethereum/ethereum-org-website/pull/7185/files#diff-e21cc87def62a0473f3455f9f7c5b3be2c08375050c808f2cb6cdd08f2664c71>
(127)
Patch Links:
- https://github.com/ethereum/ethereum-org-website/pull/7185.patch
- https://github.com/ethereum/ethereum-org-website/pull/7185.diff
—
Reply to this email directly, view it on GitHub
<#7185>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWVHH4RMNVJRSBZO5T5OJJDVV4TR5ANCNFSM54UBK6RA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Christina Vongphit iPhone
|
Description
Before:
After: