Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Wallet upgrades 💰 #7250

Closed
11 of 19 tasks
corwintines opened this issue Jul 29, 2022 · 6 comments
Closed
11 of 19 tasks

Epic: Wallet upgrades 💰 #7250

corwintines opened this issue Jul 29, 2022 · 6 comments
Assignees
Labels
epic 💪 This issue is an epic on our product roadmap feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@corwintines
Copy link
Member

corwintines commented Jul 29, 2022

Is your feature request related to a problem? Please describe.

In Q2 the Find Wallet page was revamped (#6274). While this was a large release that introduced substantial changes to the data gathered on wallets and how users can filter and find a wallet, there are still some remaining features and clean-up items that would improve the find wallet page. In Q3 the find wallets page will be iterated on to introduce additional improvements that were scoped out of the initial release.

There is also some cleanup around ethereum.org that needs to be done now that wallet data is being sourced from a new file. In Q3 this cleanup work will be addressed.

This quarter we will tackle:

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

@corwintines corwintines added the feature ✨ This is enhancing something existing or creating something new label Jul 29, 2022
@minimalsm
Copy link
Contributor

Rename EIP-1559 to "Gas fee optimization"

Are these the same thing? To me:

  • EIP-1559 is gas optimisation at the protocol level
  • But you can also have gas optimisation at the wallet level (controlling your own gas limit)

@corwintines
Copy link
Member Author

I view the second part to be more gas fee customization. For reference, we pulled this name from the discussion in this issue: #2715

Happy to discuss a better name than 'Gas fee optimization' though. Any suggestions?

@samajammin samajammin added the epic 💪 This issue is an epic on our product roadmap label Aug 2, 2022
@samajammin
Copy link
Member

Noting this epic is part of our Q3 roadmap: #7166

@samajammin
Copy link
Member

Rename EIP-1559 to "Gas fee optimization"

Encourage more workshopping of the terminology we want to use for EIP-1559 type 2 txs but for now I agree with @corwintines that "Gas fee optimization" is the best approach. As he mentioned, "Gas fee customization" is the ability for users to customize their txs, such as explicitly setting priority fee, max fee, gas limit, etc.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 24, 2022
@corwintines
Copy link
Member Author

You can find a full summary of Q3 2022 above, but in Q3 we knocked out some cleanup work this quarter to remove unused data in the codebase for wallets and added ~10 new wallets to give users more options, particularly for hardware wallets. Work will be carrying over into Q4, especially on UX improvements, which we've created issues for Hacktoberfest to give the community ways to contribute.

Issues have been opened for the outstanding items above so that we can close this epic.

#9209
#9210
#9211
#8172
#8169
#8167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic 💪 This issue is an epic on our product roadmap feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

3 participants