Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types of wallets section of wallets page #7320

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Update types of wallets section of wallets page #7320

merged 3 commits into from
Aug 12, 2022

Conversation

corwintines
Copy link
Member

Description

  • Update title Types of wallet to Types of wallet interfaces
    • Context on this, thought it was worth differentiating that these are the types of ways to interface with an account. Types of wallets to me is more Private key, smart contract, MPC. Not necessarily the device which this is providing information on.
  • Add a short description
  • Add Brower Extensions as a type of wallet interface.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Aug 5, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 5, 2022 •
edited
Loading

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 11m

samajammin
samajammin reviewed Aug 9, 2022
View reviewed changes
src/intl/en/page-wallets.json Outdated
@@ -53,8 +53,10 @@
"page-wallets-try-dapps": "Try some dapps",
"page-wallets-try-dapps-alt": "An illustration of Ethereum community members working together",
"page-wallets-try-dapps-desc": "Dapps are applications built on Ethereum. They’re cheaper, fairer and kinder on your data than most traditional applications.",
"page-wallets-types": "Types of wallet",
"page-wallets-web-browser": "Web wallets that let you interact with your account via a web browser",
"page-wallets-types": "Types of wallet interfaces",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm so what is a "wallet" vs. what is a "wallet interface"? This now confuses me a bit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me these are still "types of wallets". Not convinced we should introduce yet more jargon.

samajammin
samajammin suggested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a couple changes. Curious what other folks think here.

@Sagor2214 Sagor2214 mentioned this pull request Aug 9, 2022
Closed
@konopkja
Copy link
Contributor

Description

  • Update title Types of wallet to Types of wallet interfaces

    • Context on this, thought it was worth differentiating that these are the types of ways to interface with an account. Types of wallets to me is more Private key, smart contract, MPC. Not necessarily the device which this is providing information on.

  • Add a short description

  • Add Brower Extensions as a type of wallet interface.

this assumes others also have this background knowledge about smart contract, private key etc. I agree with Sam here, that this level of detail maybe unnecessary to differentiate.

corwintines and others added 2 commits August 10, 2022 16:48
@corwintines @samajammin
Update src/intl/en/page-wallets.json
4e950c8 
Co-authored-by: Sam Richards <sbrichards@gmail.com>
@corwintines @samajammin
Update src/intl/en/page-wallets.json
ae921aa 
Co-authored-by: Sam Richards <sbrichards@gmail.com>
@corwintines
Copy link
Member Author

Thanks for the input @samajammin @konopkja . Brought in the change requests. I think this should be good now!

@samajammin samajammin merged commit a658b94 into dev Aug 12, 2022
@samajammin samajammin deleted the update-type-of-wallets branch August 12, 2022 22:16
@corwintines corwintines mentioned this pull request Aug 15, 2022
Merged
@corwintines corwintines mentioned this pull request Oct 19, 2022
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samajammin samajammin samajammin approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corwintines @konopkja @samajammin