Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WalletCsv.ts and accompanying code #7367

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Remove WalletCsv.ts and accompanying code #7367

merged 1 commit into from
Aug 10, 2022

Conversation

corwintines
Copy link
Member

Description

  • Remove WalletCsv.ts
  • Remove any code using WalletCsv.ts

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 9, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 28m

@samajammin
Copy link
Member

While this does remove this /builders/ code that is no longer used, I'm left wondering if we could take a similar approach with the current walletData implementation?

I feel like the /builders/ approach is much cleaner than this massive GraphQL query to define every wallet image:
https://github.com/ethereum/ethereum-org-website/blob/dev/src/pages/wallets/find-wallet.tsx#L548

Curious your thoughts @pettinarip. Or is this a downside of using a TS file vs. using a CSV/JSON file via GraphQL to query this wallet data?

@pettinarip
Copy link
Member

Curious your thoughts @pettinarip. Or is this a downside of using a TS file vs. using a CSV/JSON file via GraphQL to query this wallet data?

Hmmm I'm not sure if you could load the TS file with gatsby-source-filesystem and keep doing the same...I don't think that would work because you will also need a transformer to understand that file. I don't think it is worth it.

From the data perspective, I would keep doing what @corwintines is doing, basically importing the file directly. With the images...we could investigate a bit if we can load all the images inside a specific folder (/wallets) at once. Perhaps we could do something like:

{
  allFile(filter: {absolutePath: {regex: "/(wallets)/"}}) {
    edges {
      node {
        childImageSharp {
          gatsbyImageData(layout: FULL_WIDTH, placeholder: BLURRED, quality: 100)
        }
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants