Fix potentially uninitialized padded_code #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 30 30
Lines 4198 4198
=======================================
Hits 4188 4188
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Can confirm this mod completely solves our issue on MSVC Release builds |
|
Fixed in #370. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes erigontech/silkworm#305. Consensus test
randomStatetest445_d0g0v0_Berlinwas intermittently failing on Windows. Kudos to Andrea Lanfranchi for initial investigation.