Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potentially uninitialized padded_code #368

Closed
wants to merge 3 commits into from
Closed

Fix potentially uninitialized padded_code #368

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1471c2c
Fix potentially unitialized padded_code
yperbasis Jul 29, 2021
dc32466
Fix MSVC warning
yperbasis Jul 29, 2021
03038c3
Merge branch 'master' into fix_unit
AndreaLanfranchi Jul 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/evmone/baseline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ CodeAnalysis analyze(const uint8_t* code, size_t code_size)
// Using "raw" new operator instead of std::make_unique() to get uninitialized array.
std::unique_ptr<uint8_t[]> padded_code{new uint8_t[i + 1]}; // +1 for the final STOP.
std::copy_n(code, code_size, padded_code.get());
padded_code[i] = OP_STOP; // Set final STOP at the code end.
// Set final STOP at the code end.
std::fill_n(padded_code.get() + code_size, i + 1 - code_size, uint8_t{OP_STOP});

// TODO: Using fixed-size padding of 33, the padded code buffer and jumpdest bitmap can be
// created with single allocation.
Expand Down