evmone-t8n: Temporary fix for currentDifficulty field for exec-spec-tests #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 97.07% 97.04% -0.03%
==========================================
Files 74 74
Lines 7375 7378 +3
==========================================
+ Hits 7159 7160 +1
- Misses 216 218 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
It's done by #603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a similar workaround to that of
prevRandaobut forcurrentDifficulty.I think the main issue here from the exec-spec-tests format perspective relates to the
from_json<evmc::bytes32>function. Our inputs here are string int and string hex respectively so maybe theevmc::bytes32can't be cast from these types.