Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statetest: Fix loading difficulty for BlockInfo #603

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

rodiazet
Copy link
Collaborator

Following Spencer's fix added in #602

@rodiazet rodiazet requested a review from chfast March 28, 2023 18:23
@rodiazet rodiazet force-pushed the difficulty-loading-fix branch from 0bab382 to 913cf29 Compare March 28, 2023 18:39
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #603 (293edab) into master (fd99568) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 293edab differs from pull request most recent head 898ea5c. Consider uploading reports for the commit 898ea5c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   97.07%   97.09%   +0.02%     
==========================================
  Files          74       74              
  Lines        7375     7397      +22     
==========================================
+ Hits         7159     7182      +23     
+ Misses        216      215       -1     
Flag Coverage Δ
blockchaintests 63.71% <ø> (ø)
statetests 63.15% <71.42%> (+0.03%) ⬆️
unittests 93.93% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest_loader.cpp 88.46% <100.00%> (+0.59%) ⬆️
...est/unittests/statetest_loader_block_info_test.cpp 100.00% <100.00%> (ø)

@rodiazet rodiazet force-pushed the difficulty-loading-fix branch from 913cf29 to 8f7b843 Compare March 29, 2023 11:13
test/statetest/statetest_loader.cpp Outdated Show resolved Hide resolved
test/statetest/statetest_loader.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the difficulty-loading-fix branch from 8f7b843 to 293edab Compare March 29, 2023 12:31
@rodiazet rodiazet requested a review from chfast March 29, 2023 12:31
test/unittests/statetest_loader_block_info_test.cpp Outdated Show resolved Hide resolved
test/statetest/statetest_loader.cpp Outdated Show resolved Hide resolved
@chfast chfast changed the title Fix loading difficulty for BlockInfo statetest: Fix loading difficulty for BlockInfo Mar 29, 2023
@chfast chfast merged commit d0ef459 into master Mar 29, 2023
@chfast chfast deleted the difficulty-loading-fix branch March 29, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants