Change EOF data section kind to 0x04 and activate EOF in Prague #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
change-data-section-kind
branch
from
d019f28 to
9c26c3a
Compare
chfast
reviewed
May 15, 2023
gumb0
force-pushed
the
change-data-section-kind
branch
from
9c26c3a to
f3ed9c1
Compare
chfast
reviewed
May 16, 2023
gumb0
force-pushed
the
change-data-section-kind
branch
2 times, most recently
from
8c54d59 to
15eeced
Compare
5 tasks
gumb0
force-pushed
the
change-data-section-kind
branch
2 times, most recently
from
11e6b69 to
d428079
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 97.43% 97.42% -0.01%
==========================================
Files 83 83
Lines 8042 8052 +10
==========================================
+ Hits 7836 7845 +9
- Misses 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
change-data-section-kind
branch
from
d428079 to
57aa098
Compare
gumb0
changed the title
gumb0
force-pushed
the
change-data-section-kind
branch
2 times, most recently
from
c112154 to
7f89c95
Compare
|
Current status: tests from ethereum/tests#1238 are passing, but they shouldn't be, because stack overflow check is incorrect in CALLF currently and there are wrong expectations in 5450 tests. Plan:
|
gumb0
force-pushed
the
change-data-section-kind
branch
from
7f89c95 to
6b35712
Compare
chfast
reviewed
Aug 3, 2023
| @@ -79,7 +79,7 @@ TEST_P(evm, callf_with_inputs_stack_size_1024) | |||
| return; | |||
|
|
|||
| rev = EVMC_CANCUN; | |||
| const auto code = bytecode{"ef0001 010008 020002 0BFF 0004 030000 00 000003FF 03030004"_hex} + | |||
There was a problem hiding this comment.
This seems to belong to the prev commit.
circle.yml
Outdated
| @@ -474,7 +474,7 @@ jobs: | |||
| bin/evmone-statetest ~/tests/GeneralStateTests ~/tests/LegacyTests/Constantinople/GeneralStateTests | |||
| - download_execution_tests: | |||
| repo: ipsilon/tests | |||
| rev: runtime-stackoverflow-fix | |||
| rev: update-tests | |||
There was a problem hiding this comment.
Because of the risk of rebase or branch deletion, I try to use tags, e.g. eof-opcodes-20230619. But it's up to you in the end.
gumb0
force-pushed
the
change-data-section-kind
branch
from
6b35712 to
3e1a847
Compare
chfast
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation to introduce container sections with kind 0x03.