Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JUMPF and non-returning functions #644

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Implement JUMPF and non-returning functions #644

merged 8 commits into from
Nov 28, 2023

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented May 11, 2023 •
edited
Loading

@gumb0 gumb0 added the EOF label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #644 (2bfb485) into master (b1c9637) will decrease coverage by 0.02%.
The diff coverage is 98.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   97.72%   97.70%   -0.02%     
==========================================
  Files         108      108              
  Lines        9784    10026     +242     
==========================================
+ Hits         9561     9796     +235     
- Misses        223      230       +7
Flag Coverage Δ
blockchaintests 60.79% <0.00%> (-1.45%) ⬇️
statetests 60.31% <45.94%> (-0.26%) ⬇️
statetests-silkpre 26.80% <2.32%> (-0.50%) ⬇️
unittests 95.72% <98.24%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/advanced_instructions.cpp 100.00% <ø> (ø)
lib/evmone/baseline_instruction_table.cpp 100.00% <ø> (ø)
lib/evmone/eof.hpp 100.00% <ø> (ø)
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/eof_test.cpp 94.73% <100.00%> (+0.45%) ⬆️
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_function_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_test.cpp 100.00% <100.00%> (ø)
test/unittests/instructions_test.cpp 89.58% <ø> (ø)
test/utils/bytecode.hpp 96.03% <100.00%> (ø)
... and 1 more

@gumb0 gumb0 force-pushed the eof-jumpf branch 7 times, most recently from a3cea59 to 4034c0f Compare July 6, 2023 11:26
@gumb0 gumb0 mentioned this pull request Jul 10, 2023
Closed
@gumb0 gumb0 mentioned this pull request Jul 24, 2023
Merged
@gumb0
Copy link
Member Author

gumb0 commented Jul 24, 2023

Need to add the check similar to #619

@gumb0 gumb0 force-pushed the eof-jumpf branch 2 times, most recently from f9e1aa3 to 68d6777 Compare July 25, 2023 11:01
@gumb0 gumb0 force-pushed the eof-jumpf branch 3 times, most recently from 31bb331 to 6279dca Compare August 4, 2023 12:41
@gumb0 gumb0 changed the title Implement JUMPF Implement JUMPF and non-returning functions Aug 7, 2023
@gumb0
Copy link
Member Author

gumb0 commented Aug 9, 2023

Current status: state tests need update to change all section 0's type to non-returning.

@gumb0 gumb0 force-pushed the eof-jumpf branch 5 times, most recently from 05d41a0 to 3bc4010 Compare August 22, 2023 18:19
@gumb0 gumb0 force-pushed the eof-jumpf branch 3 times, most recently from 4e411d0 to 5e4228c Compare August 29, 2023 16:53
@gumb0 gumb0 marked this pull request as ready for review August 30, 2023 13:34
@gumb0 gumb0 requested review from axic, chfast and rodiazet September 29, 2023 10:31
This was referenced Oct 23, 2023
Merged
Closed
@gumb0 gumb0 mentioned this pull request Nov 9, 2023
Merged
chfast
chfast reviewed Nov 28, 2023
View reviewed changes
lib/evmone/instructions.hpp Outdated Show resolved Hide resolved
test/unittests/eof_validation_test.cpp
"000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
"000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
"0000000000000000000000000000000000000000";
auto code = bytecode{"ef0001 010ffc 0203ff"} + 1023 * bytecode{"0001"} + "040000 00" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice compression.

@gumb0 gumb0 merged commit 56641dc into master Nov 28, 2023
24 of 25 checks passed
@gumb0 gumb0 deleted the eof-jumpf branch November 28, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-dc hugo-dc hugo-dc left review comments

@pdobacz pdobacz pdobacz approved these changes

@chfast chfast chfast approved these changes

@axic axic Awaiting requested review from axic

@rodiazet rodiazet Awaiting requested review from rodiazet

Assignees
No one assigned
Labels
EOF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gumb0 @hugo-dc @chfast @pdobacz