Disallow unreferenced subcontainers and subcontainers referenced by both EOFCREATE and RETURNCONTRACT

[gumb0]

• Disallow unreferenced subcontainers, following the spec change Add validateion rule forbidding unreferenced subcontainers ipsilon/eof#122.
• Disallow EOFCREATE and RETURNCONTRACT referencing the same container, following the spec change Disallow being referenced by both RETURNCONTRACT and EOFCREATE ipsilon/eof#135.

[codecov]

Codecov Report

Attention: Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.22%. Comparing base (449a1dc) to head (1a90105).

❗ Current head 1a90105 differs from pull request most recent head c69e5ca

Please upload reports for the commit c69e5ca to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   94.28%   94.22%   -0.06%     
==========================================
  Files         142      142              
  Lines       16123    16132       +9     
==========================================
  Hits        15201    15201              
- Misses        922      931       +9     

Flag	Coverage Δ
eof_execution_spec_tests	16.50% <10.12%> (-0.02%)	⬇️
ethereum_tests	?
ethereum_tests_silkpre	18.84% <0.00%> (-0.01%)	⬇️
execution_spec_tests	17.96% <0.00%> (-0.02%)	⬇️
unittests	89.66% <94.93%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
lib/evmone/eof.hpp	100.00% <ø> (ø)
test/eoftest/eoftest_runner.cpp	86.84% <ø> (-0.66%)	⬇️
test/unittests/eof_validation.cpp	92.50% <100.00%> (+1.66%)	⬆️
...est/unittests/state_transition_eof_create_test.cpp	100.00% <100.00%> (ø)
test/unittests/eof_test.cpp	93.75% <87.50%> (+0.72%)	⬆️
test/unittests/eof_validation_test.cpp	99.33% <98.18%> (+<0.01%)	⬆️
lib/evmone/eof.cpp	85.68% <83.33%> (-0.28%)	⬇️

... and 3 files with indirect coverage changes

[pdobacz]

LGTM, but this also implements ipsilon/eof#135 ?

[gumb0]

LGTM, but this also implements ipsilon/eof#135 ?

It does, I was not sure if it makes sense to split them.

[pdobacz]

LGTM, but this also implements ipsilon/eof#135 ?

It does, I was not sure if it makes sense to split them.

It's fine, just maybe include this in the title or merge message. We just merged the eof PR so having this go in here sounds good.