-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw): EOF - Add containerKind
to EOF fixtures, add --initcode
flag when calling evmone-eofparse
#651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
force-pushed
the
eof-test-initcode-flag
branch
from
June 26, 2024 18:13
9820fec
to
74ba61b
Compare
marioevz
changed the title
feat(fw): EOF - Add
feat(fw): EOF - Add Jun 26, 2024
initcode
flagcontainerKind
to EOF fixtures, add --initcode
flag when calling evmone-eofparse
shemnon
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
shemnon
approved these changes
Jun 26, 2024
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Jun 28, 2024
This is the fixture format agreed on EOF implementers call and produced by EEST in ethereum/execution-spec-tests#651 Based on #916 because it removes the tests for `initcode_runtime` container kind, and those were failing the run of exported validation tests.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Jul 3, 2024
Add support for `"containerKind"` in the EOF validation JSON tests. Specified in ethereum/execution-spec-tests#651.
pdobacz
pushed a commit
to ethereum/evmone
that referenced
this pull request
Jul 3, 2024
Add support for `"containerKind"` in the EOF validation JSON tests. Specified in ethereum/execution-spec-tests#651. (cherry picked from commit f552184)
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Jul 3, 2024
Add support for `"containerKind"` in the EOF validation JSON tests. Specified in ethereum/execution-spec-tests#651.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Jul 3, 2024
Add support for `"containerKind"` in the EOF validation JSON tests. Specified in ethereum/execution-spec-tests#651.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Introduces
kind
field in theContainer
class and theEOFTest
class, used to mark a container as a specific kind of container, such as "INITCODE".When the field is set:
evmone-eofparse
is called with the--initcode
flagcontainerKind: "INITCODE"
field in all vectors, by default it containscontainerKind: "RUNTIME"
.Example of a test fixture JSON file after this change:
🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.