Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eoftest: Add support for "containerKind" #943

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Jul 3, 2024

Add support for "containerKind" in the EOF validation JSON tests.
Specified in ethereum/execution-spec-tests#651.

@chfast chfast requested review from gumb0 and pdobacz July 3, 2024 08:49
@chfast
Copy link
Member Author

chfast commented Jul 3, 2024

We may want to add some unit tests for this format.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (a7aa2a9) to head (6f731ef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #943   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         142      142           
  Lines       16119    16120    +1     
=======================================
+ Hits        15199    15200    +1     
  Misses        920      920           
Flag Coverage Δ
eof_execution_spec_tests 16.51% <25.00%> (-0.01%) ⬇️
ethereum_tests 26.99% <25.00%> (-0.01%) ⬇️
ethereum_tests_silkpre 18.70% <0.00%> (-0.01%) ⬇️
execution_spec_tests 17.98% <0.00%> (-0.01%) ⬇️
unittests 89.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/eoftest/eoftest_runner.cpp 87.87% <100.00%> (+0.37%) ⬆️
test/unittests/eof_validation.cpp 92.98% <100.00%> (ø)

Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I cherry picked this to combine with bumping EEST release to 1.0.5 to see if everything works.

re unit test - since we have none for eoftest at the time, let's maybe punt this to an issue?

@chfast
Copy link
Member Author

chfast commented Jul 3, 2024

I simplified it to handle only what we need.

Add support for `"containerKind"` in the EOF validation JSON tests.
Specified in ethereum/execution-spec-tests#651.
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also good like this 👍

@chfast chfast merged commit b4f36d5 into master Jul 3, 2024
26 checks passed
@chfast chfast deleted the tests/eof_container_kind branch July 3, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants