-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eoftest: Add support for "containerKind" #943
Conversation
We may want to add some unit tests for this format. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 142 142
Lines 16119 16120 +1
=======================================
+ Hits 15199 15200 +1
Misses 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I cherry picked this to combine with bumping EEST release to 1.0.5 to see if everything works.
re unit test - since we have none for eoftest at the time, let's maybe punt this to an issue?
I simplified it to handle only what we need. |
Add support for `"containerKind"` in the EOF validation JSON tests. Specified in ethereum/execution-spec-tests#651.
f552184
to
6f731ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also good like this 👍
Add support for
"containerKind"
in the EOF validation JSON tests.Specified in ethereum/execution-spec-tests#651.