Disallow truncated data in toplevel containers #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
tests-fobid-runtime-truncated
branch
2 times, most recently
from
f71b993
to
ebc6635
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #921 +/- ##
==========================================
- Coverage 95.15% 95.08% -0.07%
==========================================
Files 140 138 -2
Lines 15785 15771 -14
==========================================
- Hits 15020 14996 -24
- Misses 765 775 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
tests-fobid-runtime-truncated
branch
from
ebc6635
to
3812727
Compare
gumb0
force-pushed
the
tests-fobid-runtime-truncated
branch
from
3812727
to
c65a79f
Compare
chfast
approved these changes
Jun 5, 2024
|
This needs updating tests in ethereum/tests cc @hugo-dc |
Disallow truncated data section in toplevel containers. This is now only allowed in some subcontainers. Co-authored-by: Paweł Bylica <pawel@ethereum.org>
The check is now part of validation of toplevel container. For creation transaction this is still required to be checked before validation to find out container/input data split.
chfast
force-pushed
the
tests-fobid-runtime-truncated
branch
from
c65a79f
to
d813e73
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only affects what is allowed in tests. Truncated data sections are not allowed at top level now, to check truncated data rules, tests should put it into subcontainers.