feature: Add engine API forkchoice updated information in fixtures #256
Conversation
spencer-tb
force-pushed
the
forkchoice-in-fixtures
branch
from
8d00032 to
1dd0e4c
Compare
|
Please note that this extra information is somewhat redundant as currently we only really need the forkchoice version within the pyspecs simulator, and at the moment this is equal to the EngineNewPayload version. On the other hand ✋, it makes the EngineAPI information more complete and future proof. We may get more some use out of it moving forward for other simulators, i.e |
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
A few comments but no full review yet.
|
Only keeping the fcu version for now as we don't have a definitive use for payload attributes at the moment. |
spencer-tb
force-pushed
the
forkchoice-in-fixtures
branch
2 times, most recently
from
4c1a641 to
f5c5e79
Compare
spencer-tb
force-pushed
the
forkchoice-in-fixtures
branch
from
19a1453 to
b363ee8
Compare
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
I think it's ok as is right now, but I would much rather keep this out of the filling logic, and keep it inside of the spec generator logic, because if we refactor the state tests, there is no place in the state test format for forkchoice updated or anything like that, so this would be something that only the blockchain test format would require.
2 participants
Similar to the following PR: #183 but for engine API forkchoice updated payload attriubes & version.
This information can be extracted and utilized in hive. Tagging ethereum/hive#830.