improvement: Fixture generation split based on hive specificity #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
force-pushed
the
hive-fixture-refactor
branch
from
4b22473 to
1846843
Compare
spencer-tb
force-pushed
the
hive-fixture-refactor
branch
from
1846843 to
f0c16b5
Compare
…d specific fixture output.
…ith distict fixture generation.
spencer-tb
force-pushed
the
hive-fixture-refactor
branch
from
e4fd95d to
139f277
Compare
spencer-tb
commented
Sep 20, 2023
Collaborator
Author
|
Tests for the hive fixture format have been added for reference, for any additional changes. The hive fixture format is consumable in the pyspec simulator - tagging: ethereum/hive#844 These have been updated for both solc version |
marioevz
approved these changes
Sep 21, 2023
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM!
We can leave the fixture refactor for a follow up PR.
5 tasks
This was referenced Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates fixture generation such that it is split into 2 seperate formats. The format is determined by the
--enable-hiveflag:--disable-hiveflag has been replaced by the--enable-hiveflag. I decided to flip this due to increasing queries about the extra hive fields within the fixtures.--enable-hiveflag, the default format is used. Client teams use this within there CI/CD.--enable-hivean new fixture format is generated, similar to the current but only with the fields required by the hive pyspec simulator.Note: after we merge this PR we will have to start including 2 tar files within every new release. One for the default fixture format
fixtures.tar.gzand another for the hive fixture formatfixtures_hive.tar.gz.