-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opcodes to "Lists" documentation #764
Conversation
Add a summary of used, pending, and proposed opcodes for the EVM Also adds a list describing each 16 opcode block,
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 570 570
Lines 31557 31557
=======================================
Hits 23356 23356
Misses 8201 8201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* add fully expanded chart to pending opcodes.
@SamWilsn @lightclient can I get a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a perfectly reasonable. In the long term it would be nice to auto generate from the specs, but we are nowhere near that at the moment.
|
Follows the opcode re-assignment of proposed instructions specified in ethereum/execution-specs#764.
Follows the opcode re-assignment of proposed instructions specified in ethereum/execution-specs#764.
Follows the opcode re-assignment of proposed instructions specified in ethereum/execution-specs#764.
Follows the opcode re-assignment of proposed instructions specified in ethereum/execution-specs#764.
Co-authored-by: Paweł Bylica <chfast@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have applied changes in ethereum/evmone#665 and we are happy with it.
I'm only slightly concerned that there is some duplication of information in these 3 tables.
Follows the opcode re-assignment of proposed instructions specified in ethereum/execution-specs#764.
Add a summary of used, pending, and proposed opcodes for the EVM.
Also adds a list describing each 16 opcode block,
Cute Animal Picture