Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-assign opcodes proposed for Cancun (+EOF) #1228

Closed
wants to merge 3 commits into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 19, 2023

Applies cleanup to opcodes ordering specified in ethereum/execution-specs#764.

@winsvega
Copy link
Collaborator

[src/Templates/EOF1/EOF1-generator.js](https://github.com/ethereum/tests/pull/1228/files#diff-a698585921b09957be089db27093403d50c4e4a15d3a89f839b9c08e6271ce83)
to parametrize the tests better we now use python tests and to avoid other generator scripts.

https://github.com/ethereum/execution-spec-tests

retesteth remain supported for simple Filler.json Filler.yml test fillers

@chfast
Copy link
Member Author

chfast commented Jun 19, 2023

I only updated existing tests. You can remove the script I'm not the author.

@qbzzt
Copy link
Collaborator

qbzzt commented Jun 19, 2023

Do you want me to convert the template tests to Python? IIRC, I wrote most of them.

@winsvega
Copy link
Collaborator

winsvega commented Jun 21, 2023

if the test works it is fine for now, but eventually parametrized tests are better to be moved to python. idk if its a good idea to rewrite it at the moment since might be double work.

some fillers are not generated

Error: Test /home/travis/build/ethereum/tests/EOFTests/EIP5450/validInvalid.json is outdated. Filler hash is different! ('aa65' != '011b')

@chfast
Copy link
Member Author

chfast commented Jun 22, 2023

It was easy to update the script this time. I think this is fine at this point (the modification is because of the spec change).

@shemnon
Copy link
Contributor

shemnon commented Jun 27, 2023

Should these be targeting another fork other than Cancun? Or use the +EIP notation? (but which EIP?)

@gumb0
Copy link
Member

gumb0 commented Aug 9, 2023

Opcodes change is now included in #1238, this can be closed.

@winsvega winsvega closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants