-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language server async overhaul #1022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
micahscopes
force-pushed
the
language-server-async
branch
from
November 30, 2024 03:46
c6920f9
to
4b6db68
Compare
micahscopes
force-pushed
the
language-server-async
branch
from
November 30, 2024 03:49
4b6db68
to
d6efd9a
Compare
micahscopes
force-pushed
the
language-server-async
branch
from
November 30, 2024 07:10
dce2214
to
bbc2abc
Compare
micahscopes
force-pushed
the
language-server-async
branch
from
November 30, 2024 07:11
bbc2abc
to
fcf416e
Compare
sbillig
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new code looks nice! Looking forward to using this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
tower-lsp
based prototype was full of issues. See #979 for details.This version is way better. In addition to the architecture overhaul, this PR includes a bunch of features and stability fixes.
Changes
tower-lsp
toasync-lsp