Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server async overhaul #1022

Merged
merged 110 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
f3eb394
Start moving LSP server to tower
micahscopes Jan 11, 2024
cab3f5f
tower-lsp logging
micahscopes Jan 12, 2024
d045742
language server clippy/fmt
micahscopes Jan 12, 2024
342ed15
language server tower refactor minor cleanup
micahscopes Jan 15, 2024
b725c73
language server tower-lsp refactor cleanup; WIP
micahscopes Jan 18, 2024
5f16c0a
language server clippy/fmt
micahscopes Jan 19, 2024
2cca5cc
Language server prevent deadlocks
micahscopes Jan 22, 2024
cb73f2f
language server: clarify async shared state design
micahscopes Jan 26, 2024
a6fc9f8
language server code cleanup
micahscopes Jan 26, 2024
fb604a9
workspace file removal improvement
micahscopes Jan 29, 2024
96ee056
generate LSP event channels automatically
micahscopes Feb 29, 2024
8d293f3
attempt at oneshot responses
micahscopes Mar 1, 2024
8256a32
stream handlers for LSP functionality
micahscopes Mar 1, 2024
ff0567f
formatting and cleanup
micahscopes Mar 1, 2024
3b7711f
language server concurrency progress
micahscopes Mar 1, 2024
a46995d
no deadlocks
micahscopes Mar 1, 2024
1d5a9a8
no need for state locks!
micahscopes Mar 1, 2024
99858f7
goto, hover; prevent panic in LSP channel response
micahscopes Mar 5, 2024
6e91765
formatting
micahscopes Mar 5, 2024
f237a21
clippy
micahscopes Mar 5, 2024
567d66b
pull some LSP channel code out of proc macro for better debugging
micahscopes Mar 5, 2024
16235bc
avoid unnecessary manual spawns
micahscopes Mar 5, 2024
1bfa3ae
separate tokio runtime for stream handling
micahscopes Mar 6, 2024
88d8128
generated struct name customization
micahscopes Mar 6, 2024
722508e
lsp channel responder cleanup
micahscopes Mar 6, 2024
952d042
cleanup; remove unneeded lock
micahscopes Mar 6, 2024
b3e09d9
exclude language-server from wasm tests
micahscopes Mar 6, 2024
5eabca8
formatting
micahscopes Mar 6, 2024
654a943
separate workspace file methods by mutability
micahscopes Mar 8, 2024
c153e72
language server get rid of unnecessary mutable references
micahscopes Mar 8, 2024
4db4708
language server: even Arc/RwLock wrapped salsadb is not Send/Sync
micahscopes Mar 8, 2024
cc304d7
language server: reflock issues are due to salsa!
micahscopes Mar 8, 2024
e94e581
Revert "language server: reflock issues are due to salsa!"
micahscopes Mar 10, 2024
e04e852
Revert "language server: even Arc/RwLock wrapped salsadb is not Send/…
micahscopes Mar 10, 2024
93f8c5c
language server snapshot mechanism
micahscopes Mar 10, 2024
0c04004
multithreaded diagnostics
micahscopes Mar 11, 2024
c439d04
language server: use mpsc instead of broadcast channels
micahscopes Mar 11, 2024
961a261
language server: proc macro cleanup
micahscopes Mar 11, 2024
56ae023
language server buffer/release mechanism
micahscopes Mar 11, 2024
10731c2
buffer/release stream
micahscopes Mar 11, 2024
186c4bf
higher order stream buffer
micahscopes Mar 12, 2024
f7d8963
language server tweaks
micahscopes Mar 12, 2024
9e53474
use unbounded channels
micahscopes Mar 12, 2024
740b267
language server tower-lsp rewrite cleanup
micahscopes Mar 14, 2024
d1a34ef
workspace cleanup; fix panic
micahscopes Mar 19, 2024
c6f18bc
formatting
micahscopes Mar 19, 2024
cd986ce
remove unused stream modifier; rustfmt
micahscopes Mar 19, 2024
95c4368
language server: load fe std lib in language server
micahscopes Mar 19, 2024
ee85ce7
batched ingot-wide diagnostics; cleanup
micahscopes Mar 19, 2024
2e16197
test files for language server hover docs
micahscopes Mar 19, 2024
96e86f0
language server: use `tracing` and `tracing-subscriber`
micahscopes Mar 27, 2024
dd14d7b
temporarily suppress dead code warning
micahscopes Mar 27, 2024
d627cd1
langauge server channel macro docs
micahscopes Mar 28, 2024
f9f46dd
cleanup stream/backend organization
micahscopes Mar 28, 2024
152641d
more language server reorganization
micahscopes Mar 28, 2024
7c2c64e
vscode extension comment toggling, autoclose
micahscopes Mar 28, 2024
d258389
remove unused dependencies from language server
micahscopes Mar 28, 2024
de34f14
improved go-to and hover functionality
micahscopes Mar 28, 2024
cb64f04
fix hanging diagnostic workers
micahscopes Mar 28, 2024
7f0b3f9
no need for workspace lock
micahscopes Mar 28, 2024
7e2029a
cleanup hover/diagnostic handlers
micahscopes Mar 28, 2024
2ac40d6
cleanup language server database
micahscopes Mar 28, 2024
17272e2
Applied some suggestions from review
micahscopes Apr 1, 2024
8fb93fb
Apply suggestions from code review
micahscopes Apr 1, 2024
1a829c3
Integrate review suggestions
micahscopes Apr 1, 2024
7fd3342
Implement @y-nak's suggested goto improvements
micahscopes Apr 1, 2024
ecd8c22
Initial work moving to async-lsp
micahscopes Jun 28, 2024
afe6fd5
add actor dispatcher abstraction
micahscopes Jul 28, 2024
1d26d51
parameterize actor dispatcher type
micahscopes Jul 28, 2024
5711d01
Decouple `Actor`, `ActorRef` and `Dispatcher`
micahscopes Jul 30, 2024
d22a7da
compiling
micahscopes Jul 30, 2024
03e7938
State of the code during Jul. 30 weekly meeting
micahscopes Jul 30, 2024
ace2107
compiling, still not initializing
micahscopes Sep 18, 2024
9385c1d
clippy/rustfmt
micahscopes Sep 18, 2024
e00636f
getting closer
micahscopes Sep 18, 2024
b4b8556
graceful lsp fallback for error handling
micahscopes Sep 20, 2024
6607268
error handling improvements
micahscopes Sep 21, 2024
bee08d9
further debugging...
micahscopes Sep 23, 2024
a8ad476
add TCP support
micahscopes Sep 24, 2024
9d5109c
use async-std's stdio
micahscopes Sep 24, 2024
69839da
attempts to fix LSP logging
micahscopes Sep 24, 2024
28fd8c6
multithreaded/multi-client tracing proof of concept
micahscopes Sep 30, 2024
0bcef56
LSP actor thread names in logger
micahscopes Oct 1, 2024
8e856a4
use generic actor message keys
micahscopes Oct 10, 2024
f798fae
hooking up functionality again
micahscopes Oct 15, 2024
24cf4b0
hook up LSP diagnostics
micahscopes Oct 15, 2024
e9f68f2
get rid of warnings / rustfmt / clippy
micahscopes Oct 15, 2024
aee7bb7
salsa upgrade for LSP server
micahscopes Oct 15, 2024
47b0c54
cleanup and LSP event `CanHandle`
micahscopes Oct 15, 2024
90574ee
language server organization
micahscopes Oct 15, 2024
a7ac89c
simplify LSP setup
micahscopes Oct 15, 2024
4484871
Support for non-mutating LSP handlers
micahscopes Oct 16, 2024
8054189
non-mutable diagnostics handler
micahscopes Nov 26, 2024
fddc3c3
use language server via TCP
micahscopes Nov 26, 2024
14edc09
LSP server timeout to shutdown unused server instances
micahscopes Nov 26, 2024
08f7efe
Compute diagnostics using a worker per ingot
micahscopes Nov 26, 2024
1c0d211
appease clippy
micahscopes Nov 26, 2024
a8a3c24
use published actor lib for LSP server
micahscopes Nov 26, 2024
942ec59
rely less on async-lsp changes
micahscopes Nov 29, 2024
2e8f575
Running tests, iterating on actor module
micahscopes Jul 27, 2024
764d45a
actor is passing basic smoke test
micahscopes Jul 27, 2024
502fc6a
update progress log, roadmap
micahscopes Nov 30, 2024
d6efd9a
remove extra changes
micahscopes Nov 30, 2024
b116b92
appease clippy
micahscopes Nov 30, 2024
d400186
more fixes for clippy
micahscopes Nov 30, 2024
fa36151
clippy and compiler were fighting over these lines
micahscopes Nov 30, 2024
eef4e1a
remove unused dependencies, use different TCP listener library
micahscopes Nov 30, 2024
0df34a4
Merge branch 'fix-lifetime-elision-lint' into language-server-async
micahscopes Nov 30, 2024
0b6a311
fix lsp actor test
micahscopes Nov 30, 2024
fcf416e
fix lsp `WithFallback` service
micahscopes Nov 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
# wasm-pack needs a Cargo.toml with a 'package' field.
# (see https://github.com/rustwasm/wasm-pack/issues/642)
# This will still run all tests in the workspace.
run: wasm-pack test --node crates/fe --workspace
run: wasm-pack test --node crates/fe --workspace --exclude fe-language-server

release:
# Only run this when we push a tag
Expand Down
46 changes: 22 additions & 24 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -1,25 +1,23 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"args": [
"--extensionDevelopmentPath=${workspaceFolder}/crates/language-server/editors/vscode",
"${workspaceFolder}/crates/"
],
"name": "Launch Fe VSCode Extension",
"outFiles": [
"${workspaceFolder}/crates/language-server/editors/vscode/out/**/*.js"
],
"preLaunchTask": "compile-vscode-extension",
"request": "launch",
"type": "extensionHost",
// we need to enable backtrace on the extension host
"env": {
"RUST_BACKTRACE": "1"
}
},
]
}
"version": "0.2.0",
"configurations": [
{
"args": [
"--extensionDevelopmentPath=${workspaceFolder}/crates/language-server/editors/vscode",
"${workspaceFolder}/crates/",
"--disable-extensions"
],
"name": "Launch Fe VSCode Extension",
"outFiles": [
"${workspaceFolder}/crates/language-server/editors/vscode/out/**/*.js"
],
"preLaunchTask": "compile-vscode-extension",
"request": "launch",
"type": "extensionHost",
"env": {
"RUST_BACKTRACE": "full",
"NODE_ENV": "development"
}
}
]
}
Loading