Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go modules #20164

Closed
eccles opened this issue Oct 12, 2019 · 4 comments · Fixed by #20311
Closed

Go modules #20164

eccles opened this issue Oct 12, 2019 · 4 comments · Fixed by #20311

Comments

@eccles
Copy link

eccles commented Oct 12, 2019

Not a bug but a request/question

when is go-ethereum moving to go modules instead of using dep?

@zjiekai
Copy link

zjiekai commented Oct 13, 2019

People are working on it
#19605

@eccles
Copy link
Author

eccles commented Oct 13, 2019

Please see urfave/cli#904 where I had issues in my own repo with go get -u.
The suggestion is to use the github.com url for urfave/cli and not the gopkg.in url.

I also had problems with go-interpreter/wagon. (also pulled in by go-ethereum.)

The caveat here is that I am currently pinned to version 1.8.27 of go-ethereum due to circumstances beyond my control so I did not report this as a bug in go-ethereum.(yet)

Hope this is helpful.

@karalabe
Copy link
Member

Yes, this is something we want to do. Unfortunately we need to switch over our launchpad builders to snaps + make launchpad meta packages because Go 1.13 is not available on older versions of Ubuntu. Until that work is done, go modules are blocked.

@Pet3ris
Copy link

Pet3ris commented Oct 31, 2019

I've just filed a potentially related issue.

It seems like not only does go-ethereum not use go modules, it may not be able to be used in any go module project that invokes the indirect leveldb dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants