Recommend Go Modules in the README #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
requested review from
rliebz and
asahasrabuddhe
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
=========================================
Coverage ? 72.44%
=========================================
Files ? 33
Lines ? 2493
Branches ? 0
=========================================
Hits ? 1806
Misses ? 576
Partials ? 111Continue to review full report at Codecov.
|
saschagrunert
approved these changes
Dec 24, 2019
rliebz
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We get a steady flow of issues that are sourced in people not using Go Modules, and the recommendation has included "use Go Modules" in all of those cases. For example:
Further, we recently decided via #952 (comment) that we are not interested in supporting
GOPATHmode. To the best of my knowledge, this leaves "Go Modules" and "Vendoring" as the two remaining packaging methods that we support. Given that our clear preference here is Go Modules, I think we should update the readme to explicitly and strongly recommend Go Modules.