-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: switch to Go modules #20311
go.mod: switch to Go modules #20311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the pcsclite side
One thing I don't like about this change is that the debian source package content is no longer deterministic. As written, build/ci.go packages the entire go module cache, which could contain Alternatively, we could run |
I assume Travis' go cache is empty initially so we surely only ship what's
needed. Executing in a diff environment might break this invariant though
indeed.
β¦On Wed, Nov 20, 2019, 13:56 Felix Lange ***@***.***> wrote:
One thing I don't like about this change is that the debian source package
content is no longer deterministic. As written, build/ci.go packages the
entire go module cache, which could contain
arbitrary modules checked out locally. I think it would be better to move
the invocation of go install -n ./... into ci.go and run it with a
different cache directory, then copy that directory instead.
Alternatively, we could run go list to find the list used modules and
only copy those.
β
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20311?email_source=notifications&email_token=AAA7UGI2KQQC36WQXRW4A43QUUQWDA5CNFSM4JOSWY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEERXQ7Q#issuecomment-555972734>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7UGJXWTODNRKVVROQEWLQUUQWDANCNFSM4JOSWY4A>
.
|
+341 β811,974
πFixes #20226.
Fixes #20164.
Fixes #20342.