Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: switch to Go modules #20311

Merged
merged 9 commits into from
Nov 21, 2019
Merged

go.mod: switch to Go modules #20311

merged 9 commits into from
Nov 21, 2019

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Nov 18, 2019

+341 βˆ’811,974 😝

Fixes #20226.
Fixes #20164.
Fixes #20342.

@karalabe karalabe added this to the 1.9.8 milestone Nov 18, 2019
@karalabe karalabe requested a review from fjl November 18, 2019 17:59
.travis.yml Outdated Show resolved Hide resolved
internal/build/util.go Outdated Show resolved Hide resolved
@karalabe karalabe requested a review from ligi as a code owner November 18, 2019 20:06
@r8d8
Copy link

r8d8 commented Nov 19, 2019

#19605

@karalabe karalabe mentioned this pull request Nov 19, 2019
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the pcsclite side

@fjl
Copy link
Contributor

fjl commented Nov 20, 2019

One thing I don't like about this change is that the debian source package content is no longer deterministic. As written, build/ci.go packages the entire go module cache, which could contain
arbitrary modules checked out locally. I think it would be better to move the invocation of go install -n ./... into ci.go and run it with a different cache directory, then copy that directory instead.

Alternatively, we could run go list to find the list used modules and only copy those.

@karalabe
Copy link
Member Author

karalabe commented Nov 20, 2019 via email

@fjl fjl changed the title go.mod, vendor: switch to Go modules go.mod: switch to Go modules Nov 21, 2019
@fjl fjl merged commit 89ab8a7 into ethereum:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants