Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner, accounts/abi/bind: fix load-sensitive unit tests #20698

Merged
merged 5 commits into from
Feb 20, 2020
Merged

miner, accounts/abi/bind: fix load-sensitive unit tests #20698

merged 5 commits into from
Feb 20, 2020

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Feb 20, 2020 •
edited
Loading

ERROR OUTPUT generated by stress

--- FAIL: TestOverload (0.12s)
      overload_test.go:63: Wait bar0 event timeout

worker_test.go:247: failed to insert new mined block:2, error:unknown ancestor

--- FAIL: TestNodeDBExpiration (1.30s)
    clientpool_test.go:538: timeout
FAIL

fjl
fjl requested changes Feb 20, 2020
View reviewed changes
les/clientpool_test.go Outdated Show resolved Hide resolved
@adamschmideg adamschmideg mentioned this pull request Feb 20, 2020
Closed
20 tasks
fjl
fjl approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@fjl fjl merged commit 2e1ecc0 into ethereum:master Feb 20, 2020
@karalabe karalabe added this to the 1.9.12 milestone Mar 16, 2020
kjx98 pushed a commit to kjx98/go-ethereum that referenced this pull request Mar 17, 2020
@rjl493456442 @kjx98
les, miner, accounts/abi/bind: fix load-sensitive unit tests (ethereu…
c218bdd 
…m#20698)
@ricardolyn ricardolyn mentioned this pull request Feb 3, 2021
Merged
7 tasks
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
@rjl493456442 @enriquefynn
les, miner, accounts/abi/bind: fix load-sensitive unit tests (ethereu…
a7a216e 
…m#20698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.12
Development

Successfully merging this pull request may close these issues.
3 participants
@rjl493456442 @fjl @karalabe