[Upgrade] Go-Ethereum release v1.9.12 #1122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Plan & Analyse
As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.
Build & Test
master
into this branchExtra Changes & Tests
core/tx_pool_test.go
. 39b4817Go-Ethereum Release: Tall Moose (v1.9.12)
Release notes
Geth v1.9.12 is a small bugfix release, mostly to keep a semi-regular schedule.
One small breaking change in the release is that
eth_call
will not default to your first account any more if you don't explicitly specify a sender. This was done to avoid the same input behaving differently in different environments. You should never doeth_call
without explicitly setting a sender in the first place.Changes:
0x00...0
) account foreth_call
sender if none was specified (#20702).CallOpts.SetFrom
for mobile to permit setting a sender on calls (#20721).Fixes:
escape
andunescape
(#20700).The release also includes a few changes towards supporting Go 1.14, but the switch-over is postponed until Go 1.14.1 is released due to an issue in Go around faulty Linux kernel detection.
For a full rundown of the changes please consult the Geth 1.9.12 release milestone.
As with all our previous releases, you can find the:
ethereum/client-go
.Codebase changes assessment
Legend
File Stats: (A) Added, (M) Modified and (R) Removed
Line Stats: (A) Added and (R) Removed
Assessment:
19 Pull Requests
M/A/R
(files changed)
A/R
(lines changed)
core/vm: use dedicated SLOAD gas constant for EIP-2200
core/vm
(1)params
(1)core/vm/eips.go
(6)params/protocol_params.go
(2)go.mod: upgrade goja to latest
go.sum
(1)go.mod
(1)go.mod
(4)go.sum
(4)miner, accounts/abi/bind: fix load-sensitive unit tests
accounts/abi/bind
(1)les
(1)miner
(1)miner/worker_test.go
(24)accounts/abi/bind/bind_test.go
(8)les/clientpool_test.go
(8)Correct Clef typo
cmd/clef
(1)cmd/clef/tutorial.md
(4)eth/fetcher: remove randomness from test data
eth/fetcher
(1)eth/fetcher/tx_fetcher_test.go
(16)eth/downloader: fix possible data race by inconsistent field protection
eth/downloader
(1)eth/downloader/queue.go
(18)internal/ethapi: default to 0x00-account instead of local accounts for calls
internal/ethapi
(1)internal/ethapi/api.go
(48)les: separate peer into clientPeer and serverPeer
les
(25)les/peer.go
(2792)les/peer_test.go
(754)les/odr_requests.go
(152)les/client_handler.go
(122)les/benchmark.go
(106)mobile: add CallOpts.SetFrom
mobile
(1)mobile/bind.go
(2)crypto/bn256: fix import line
crypto/bn256
(1)crypto/bn256/bn256_slow.go
(4)p2p/discv5: fix test on go 1.14
p2p/discv5
(1)p2p/discv5/node_test.go
(4)rpc: correct typo and reword comment for consistency
rpc
(1)rpc/http.go
(8)Update gas.go
core/vm
(1)core/vm/gas.go
(4)tests: update tests/testdata@develop, include EIP2384 config
tests
(2)tests/difficulty_test.go
(6)tests/testdata
(4)rpc: improve cancel test
rpc
(3)rpc/client_test.go
(32)rpc/testservice_test.go
(10)rpc/server_test.go
(4)eth, les: fix time sensitive unit test
les
(7)eth
(1)les/test_helper.go
(82)les/sync_test.go
(46)les/peer.go
(28)les/client_handler.go
(10)les/server_handler.go
(6)eth: fix transaction announce/broadcast goroutine leak
eth
(1)eth/peer.go
(24)go.mod: update golang.org/x/crypto to fix a Go 1.14 race rejection
go.mod
(1)go.sum
(1)go.sum
(36)go.mod
(14)increase geth retesteth default http timeouts
cmd/geth
(1)cmd/geth/retesteth.go
(14)50 Changed files
les/peer.go
#19991
les/peer_test.go
les/test_helper.go
#19991
les/odr_requests.go
les/client_handler.go
#19991
les/benchmark.go
les/fetcher.go
les/server_handler.go
#19991
les/txrelay.go
les/handler_test.go
internal/ethapi/api.go
les/sync_test.go
#19991
go.sum
#20700
les/ulc_test.go
rpc/client_test.go
les/clientpool.go
eth/peer.go
miner/worker_test.go
les/servingqueue.go
les/distributor.go
les/client.go
eth/downloader/queue.go
go.mod
#20700
les/server.go
les/retrieve.go
les/odr_test.go
#19991
eth/fetcher/tx_fetcher_test.go
cmd/geth/retesteth.go
les/serverpool.go
les/sync.go
les/odr.go
rpc/testservice_test.go
les/clientpool_test.go
accounts/abi/bind/bind_test.go
rpc/http.go
tests/difficulty_test.go
core/vm/eips.go
les/distributor_test.go
tests/testdata
les/request_test.go
#19991
core/vm/gas.go
crypto/bn256/bn256_slow.go
params/version.go
p2p/discv5/node_test.go
rpc/server_test.go
cmd/clef/tutorial.md
eth/handler_test.go
params/protocol_params.go
mobile/bind.go
les/commons.go