Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: add CallOpts.SetFrom #20721

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Feb 27, 2020

This was missing because we forgot to wrap it when bind.CallOpts.From as added.

Fixes: #18034

This was missing because I forgot to wrap it when bind.CallOpts.From
as added.
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.12 milestone Feb 27, 2020
@karalabe karalabe merged commit cec1f29 into ethereum:master Feb 27, 2020
pull bot pushed a commit to scope-demo/go-ethereum that referenced this pull request Feb 27, 2020
This was missing because I forgot to wrap it when bind.CallOpts.From
as added.
tonyredondo pushed a commit to scope-demo/go-ethereum that referenced this pull request Feb 27, 2020
* internal/ethapi: default to zero address for calls (ethereum#20702)

This makes eth_call and eth_estimateGas use the zero address
as sender when the "from" parameter is not supplied.

Co-authored-by: Felix Lange <fjl@twurst.com>

* les: separate peer into clientPeer and serverPeer (ethereum#19991)

* les: separate peer into clientPeer and serverPeer

* les: address comments

* mobile: add CallOpts.SetFrom (ethereum#20721)

This was missing because I forgot to wrap it when bind.CallOpts.From
as added.

* crypto/bn256: fix import line (ethereum#20723)

* p2p/discv5: fix test on go 1.14 (ethereum#20724)

Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: gary rong <garyrong0905@gmail.com>
Co-authored-by: Adam Schmideg <adamschmideg@users.noreply.github.com>
kjx98 pushed a commit to kjx98/go-ethereum that referenced this pull request Mar 17, 2020
This was missing because I forgot to wrap it when bind.CallOpts.From
as added.
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
This was missing because I forgot to wrap it when bind.CallOpts.From
as added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CallOpts missing setter "From" in Android
2 participants