les: fix balance expiration #22343
Merged
les: fix balance expiration #22343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
force-pushed
the
balance-fix
branch
from
4b8021f
to
60f9a3d
Compare
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a light server bug that was introduced by the refactoring of the client pool and adds a unit test. The exponential balance expiration did not work correctly because the expirer state was saved on shutdown but not loaded at startup, therefore the calculated balance values were off. Luckily currently only the negative balances of free clients were used in production so the only issue this bug has caused was that some free clients were treated unfairly by some servers. Still, this bug can negatively affect the usability of LES so this fix should be merged and deployed to the bootnodes ASAP.
Note: the PR also moves client balances to a new and separate database. I wanted to do this change anyways because the balances do not belong to the chain db and this is a good moment because the database reset ensures that the different values of the balance expiration mechanism are in sync.