Add missing periods on end of comments #25058

lightclient · 2022-06-10T11:10:11Z

Adds a few periods at the end of function-level documentation.

s1na

LGTM

holiman

LGTM

commit 23bee16 Author: Péter Szilágyi <peterke@gmail.com> Date: Wed Jun 15 15:35:32 2022 +0300 params: release Geth v1.10.19 commit d78d302 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Wed Jun 15 14:35:53 2022 +0200 node: add info message when JWT secret is loaded (ethereum#25095) Co-authored-by: Felix Lange <fjl@twurst.com> commit d8f9638 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Wed Jun 15 13:10:38 2022 +0200 cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088) * cmd/geth, params: implement Gray Glacier (EIP-5133) * cmd/evm: add gray glacier tests * params: nitpicks * params: fixes commit 3060216 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Jun 15 18:56:47 2022 +0800 eth: introduce eth67 protocol (ethereum#24093) The new protocol version removes support for GetNodeData. See https://eips.ethereum.org/EIPS/eip-4938 for more information. Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> commit 3273ad1 Author: lightclient <14004106+lightclient@users.noreply.github.com> Date: Wed Jun 15 09:29:23 2022 +0200 eth: add missing period at end of sentences (ethereum#25058) eth: add missing periods on end of comments commit bc013bc Author: lmittmann <lmittmann@users.noreply.github.com> Date: Tue Jun 14 14:09:48 2022 +0200 all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087) minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx` commit 8cfd121 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Tue Jun 14 14:08:43 2022 +0200 common: improve pretty duration regex (ethereum#25073) * common: improve pretty duration regex * common: improve pretty duration regex commit 6ad620d Author: s7v7nislands <s7v7nislands@gmail.com> Date: Tue Jun 14 19:47:11 2022 +0800 cmd/ethkey: use accounts.TextHash (ethereum#25069) commit 1cf58c7 Author: lightclient <14004106+lightclient@users.noreply.github.com> Date: Tue Jun 14 12:59:05 2022 +0200 readme,eth: remove references to eth.wiki (ethereum#25086) commit f74bb3a Author: Ivan Aracki <aracki.ivan@gmail.com> Date: Tue Jun 14 10:24:29 2022 +0200 cmd/utils: update --ropsten description (ethereum#25078) commit a907d7e Author: Martin Holst Swende <martin@swende.se> Date: Mon Jun 13 16:24:45 2022 +0200 all: more linters (ethereum#24783) This enables the following linters - typecheck - unused - staticcheck - bidichk - durationcheck - exportloopref - gosec WIth a few exceptions. - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there. - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now. - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention. - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees. commit eb94896 Author: Gustavo Silva <GustavoRSSilva@users.noreply.github.com> Date: Fri Jun 10 16:47:06 2022 +0100 Chore: Minimal gramatical errors (signleton -> singleton) (ethereum#25057) core: fix typos commit 3f5b5ec Author: Luozhu <70309026+LuozhuZhang@users.noreply.github.com> Date: Fri Jun 10 16:57:32 2022 +0800 internal/ethapi: fix typo in comment (ethereum#25056) typo error: keccack256 -> keccak256 commit 594e321 Author: int88 <106391185+int88@users.noreply.github.com> Date: Thu Jun 9 00:40:37 2022 +0800 core/evm: fix error in comment (ethereum#25040) Co-authored-by: Martin Holst Swende <martin@swende.se> commit f503718 Author: henridf <henri@dubfer.com> Date: Wed Jun 8 18:32:07 2022 +0200 core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032) Co-authored-by: Felix Lange <fjl@twurst.com> commit 6160296 Author: Rajaram Gaunker <zimbabao@gmail.com> Date: Wed Jun 8 09:31:43 2022 -0700 core/types: remove unused field 'td' in Block (ethereum#25010) commit b60a08d Author: Martin Holst Swende <martin@swende.se> Date: Wed Jun 8 15:36:25 2022 +0200 eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997) Removes engine from any unauthenticated RPC service. commit c4dab8c Merge: 138f0d7 106a162 Author: Péter Szilágyi <peterke@gmail.com> Date: Wed Jun 8 16:34:43 2022 +0300 Merge pull request ethereum#25044 from karalabe/rpc-histograms rpc: swap out timer metrics to histograms commit 106a162 Author: Péter Szilágyi <peterke@gmail.com> Date: Wed Jun 8 16:24:33 2022 +0300 rpc: swap out timer metrics to histograms commit 138f0d7 Author: Håvard Anda Estensen <haavard.ae@gmail.com> Date: Tue Jun 7 17:27:21 2022 +0200 p2p: use errors.Is for error comparison (ethereum#24882) Co-authored-by: Felix Lange <fjl@twurst.com> commit 41e7548 Author: Péter Szilágyi <peterke@gmail.com> Date: Tue Jun 7 13:49:07 2022 +0300 eth, les, params: log chain config a bit saner (ethereum#24904) Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. This PR converts that original data dump and converts it into a user friendly - alas multiline - log output. commit 450f5da Author: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Date: Tue Jun 7 19:46:27 2022 +0900 accounts: increase parseURL test coverage (ethereum#25033) accounts/url: add test logic what check null string to parseURL() commit 403624a Author: Martin Holst Swende <martin@swende.se> Date: Tue Jun 7 12:15:22 2022 +0200 p2p/discover: fix panicky test (ethereum#25038) commit 5e8fa1d Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Tue Jun 7 09:06:34 2022 +0200 tests/fuzzers/bls12381: fix blst pairing (ethereum#25037) * tests/fuzzers/bls12381: fix blst pairing * tests/fuzzers/bls12381: only build on gofuzz * tests/fuzzers/bls12381: remove unused code * tests/fuzzers/bls12381: remove unused code commit 84b3272 Author: lwh <lwhile521@gmail.com> Date: Tue Jun 7 14:38:54 2022 +0800 accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924) * accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627 * accounts, cmd/abigen: resolve name conflicts * ci lint, accounts/abi: remove unused function overloadedArgName Co-authored-by: Gary Rong <garyrong0905@gmail.com> commit d9566e3 Author: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Date: Tue Jun 7 08:31:19 2022 +0200 eth/filters: fix getLogs for pending block (ethereum#24949) * eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation commit 7e9514b Author: Martin Holst Swende <martin@swende.se> Date: Tue Jun 7 08:11:01 2022 +0200 params: update ropsten terminal total difficulty block (ethereum#25018) commit 6b3e6cb Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Tue Jun 7 02:02:04 2022 -0400 trie: move locking into trieDB insert method (ethereum#25030) Move locking into trieDB insert function commit 096daa9 Author: Ikko Ashimine <eltociear@gmail.com> Date: Tue Jun 7 00:55:16 2022 +0900 eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020) indentifier -> identifier commit 10da980 Author: lightclient <14004106+lightclient@users.noreply.github.com> Date: Mon Jun 6 17:33:05 2022 +0200 eth/api: use `hexutil.Bytes` for account range method (ethereum#25024) eth/api: use hexutil.Bytes for range at methods commit 22defa5 Author: rjl493456442 <garyrong0905@gmail.com> Date: Mon Jun 6 23:14:55 2022 +0800 all: introduce trie owner notion (ethereum#24750) * cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se> commit c375ee9 Author: Martin Holst Swende <martin@swende.se> Date: Mon Jun 6 17:09:39 2022 +0200 cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com> commit d6b5574 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Mon Jun 6 17:01:59 2022 +0200 tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036) * tests/fuzzers/bls12381: fix blst deserializing * tests/fuzzers/bls12381: fix blst deserializing commit 997f1c4 Author: Paweł Bylica <chfast@gmail.com> Date: Fri Jun 3 10:40:14 2022 +0200 core/vm: optimize jumpdest analysis (ethereum#23500) core/vm: optimize PUSH opcode discrimination commit b453767 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Fri Jun 3 15:25:25 2022 +0800 go.mod: clean up (ethereum#25017) commit 5bc4e8f Author: Jonathan Le Brun <42697488+icyfry@users.noreply.github.com> Date: Thu Jun 2 20:26:44 2022 +0200 go.mod: set go version to 1.17 (ethereum#24926) set go version to 1.17 commit 490c45c Author: Ivan Kuznetsov <me@jeiwan.ru> Date: Fri Jun 3 01:25:12 2022 +0700 consensus/misc: reduce allocations and improve comments in CalcBaseFee (ethereum#24958) * consensus/misc: reduce allocations in CalcBaseFee * consensus/misc: add formulas of CalcBaseFee commit 6f075bf Author: Martin Holst Swende <martin@swende.se> Date: Thu Jun 2 20:21:35 2022 +0200 node: make jwt test less dependent on time (ethereum#25016) commit 2227589 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Thu Jun 2 13:15:17 2022 +0200 eth/catalyst: return 0x0 on Invalid block on top of pow block (ethereum#25006) commit 3c6d6f7 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Thu Jun 2 13:13:28 2022 +0200 tests/fuzzers/bls12381: Add BLST to fuzzing support (ethereum#24249) * tests/fuzzers/bls12381: added blst library * go.mod: added blst dependency * tests/fuzzers/bls12381: stuff * tests/fuzzers/bls12381: added blst to pairing fuzzer commit d8a2305 Author: Martin Holst Swende <martin@swende.se> Date: Thu Jun 2 11:39:36 2022 +0200 eth/tracers: add support for block overrides in debug_traceCall (ethereum#24871) This PR adds support for block overrides when doing debug_traceCall. - Previously, debug_traceCall against pending erroneously used a common.Hash{} stateroot when looking up the state, meaning that a totally empty state was used -- so it always failed, - With this change, we reject executing debug_traceCall against pending. - And we add ability to override all evm-visible header fields. commit f9806dc Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Jun 1 17:03:24 2022 +0800 core: fix canonical hash marker update (ethereum#24996) * core: fix reorg * core: revert change for memory efficiency * core: revert changes commit 8c0c043 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Tue May 31 11:11:50 2022 +0200 core/beacon: prevent invalid logsBloom length panic (ethereum#24946) * core/beacon: prevent invalid logsBloom length panic * core/beacon: prevent negative baseFeePerGas * Update core/beacon/types.go Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/catalys: go format Co-authored-by: Martin Holst Swende <martin@swende.se> commit 03157b6 Author: Boqin Qin(秦伯钦) <Bobbqqin@gmail.com> Date: Tue May 31 02:35:37 2022 +0800 eth/filters: use buffered channel to avoid goroutine leak (ethereum#24928) commit 2140aab Author: Martin Holst Swende <martin@swende.se> Date: Mon May 30 14:45:27 2022 +0200 contracs/checkpointoracle: fix directives (ethereum#24944) contracts/checkpointoracle: redefine go-generate logic commit 93fe175 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Mon May 30 13:28:15 2022 +0200 eth/catalyst: fix edge case in NewPayload (ethereum#24955) Fixes an issue where we would accept a NewPayload where the grandparent is already post ttd, and the parent still has a Difficulty commit 8845227 Author: Harry Kalodner <harry.kalodner@gmail.com> Date: Mon May 30 07:00:23 2022 -0400 consensus/clique: fix race condition (ethereum#24957) * consensus/clique: remove race condition * consensus/clique: fix one more signer data race Co-authored-by: Gary Rong <garyrong0905@gmail.com> commit a10660b Author: rjl493456442 <garyrong0905@gmail.com> Date: Mon May 30 18:37:42 2022 +0800 cmd/geth: extend traverseRawState command (ethereum#24954) This PR adds node verification into traverseRawState command, so corrupted trie nodes can also be detected. commit 86af788 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Mon May 30 08:42:06 2022 +0200 core: use less memory during reorgs (ethereum#24616) This PR significantly reduces the memory consumption of a long reorg commit be97427 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Fri May 27 08:23:55 2022 +0200 params: set emergency ropsten TTD to 100_000_000_000_000_000_000_000 (ethereum#24975) commit 0287e1a Author: Martin Holst Swende <martin@swende.se> Date: Thu May 26 09:26:37 2022 +0200 cmd/abigen: accept combined-json via stdin (ethereum#24960) commit 0559a9a Author: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Date: Thu May 26 09:22:10 2022 +0200 cmd/geth: exit when freezer has legacy receipts (ethereum#24943) In ethereum#24028 we flagged a warning when finding legacy receipts in the freezer. This PR nudges users a bit more strongly by preventing geth from starting in this case until receipts have been migrated. It also adds a flag --ignore-legacy-receipts which when present allows geth to start normally. commit d575a2d Author: Felix Lange <fjl@twurst.com> Date: Wed May 25 14:44:52 2022 +0200 params: begin v1.10.19 release cycle

eth: add missing periods on end of comments

@rjl493456442

* params: begin v1.10.18 release cycle * rlp: fix typo in comment (ethereum#24595) Co-authored-by: Yong Yang <yangyong775654@163.com> * core/state/snapshot: clean up the generation code (ethereum#24479) * go.mod : upnp 1.0.3 stable version (ethereum#24573) * internal/ethapi: add refund to StructLogRes (ethereum#24567) * internal/ethapi: add refund to StructLogRes * Update internal/ethapi/api.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * eth/tracers/logger: use omitempty to reduce log bloat (ethereum#24547) Makes the evm json output less verbose: omitting output of `memory` and `returndata` in case they are empty. * common/compiler: add extra include paths to solidity compiler (ethereum#24541) This PR adds a ExtraAllowedPath field to Solidity and exposes two APIs: CompileSource and CompileFiles, which were hidden inside CompileSolidityString and CompileSolidity before. * core: verify genesis extradata for clique (ethereum#24470) * Add extra-data checks for clique genesis * Update genesis.go * Update genesis.go * core: simplify clique genesis check Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * eth: change snapshot extension registration failure to warning instead of error (ethereum#24475) * core: Change Snapshot extension registration failed to Debug * Update eth/handler.go Co-authored-by: Martin Holst Swende <martin@swende.se> * trie, les, tests, core: implement trie tracer (ethereum#24403) Trie tracer is an auxiliary tool to capture all deleted nodes which can't be captured by trie.Committer. The deleted nodes can be removed from the disk later. * core,eth: implement tx-level hooks for tracers (ethereum#24510) * core,eth: add empty tx logger hooks * core,eth: add initial and remaining gas to tx hooks * store tx gasLimit in js tracer * use gasLimit to compute intrinsic cost for js tracer * re-use rules in transitiondb * rm logs * rm logs * Mv some fields from Start to TxStart * simplify sender lookup in prestate tracer * mv env to TxStart * Revert "mv env to TxStart" This reverts commit 656939634b9aff19f55a1cd167345faf8b1ec310. * Revert "simplify sender lookup in prestate tracer" This reverts commit ab65bce48007cab99e68232e7aac2fe008338d50. * Revert "Mv some fields from Start to TxStart" This reverts commit aa50d3d9b2559addc80df966111ef5fb5d0c1b6b. * fix intrinsic gas for prestate tracer * add comments * refactor * fix test case * simplify consumedGas calc in prestate tracer * eth: clarify the error string on getlogs failure (ethereum#24617) This PR makes the errors we spit out a bit more clear about what block is problematic. * eth/downloader: retrieve pivot header from local chain if necessary (ethereum#24610) * eth/downloader: retrieve pivot header from local chain if necessary * eth/downloader: improve readability * eth/downloader: update fix * eth/downloader: add beacon sync tests * eth/downloader: remove duplicated code * README: update free space required (ethereum#24636) * rpc: fixed a typo (ethereum#24642) * eth/fetcher: if peers never respond, drop them * eth/tracers: refactor traceTx to separate out struct logging (ethereum#24326) * eth/tracers: refactor traceTx to separate out struct logging review fix Update eth/tracers/api.go Co-authored-by: Martin Holst Swende <martin@swende.se> Mv ExecutionResult type to logger package review fix impl GetResult for StructLogger make formatLogs private confused exit and end.. account for intrinsicGas in structlogger, fix TraceCall test Add Stop method to logger Simplify traceTx Fix test rm logger from blockchain test account for refund in structLogger * use tx hooks in struct logger * minor * avoid executionResult in struct logger * revert blockchain test changes * README: remove mentions of fast sync (ethereum#24656) Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * core/state/snapshot: remove noop map item assignment * cmd/geth: inspect snapshot dangling storage (ethereum#24643) * cmd/geth: inspect snapshot dangling storage * cmd/geth: make verify-state invoke verify-dangling * accounts/abi: handle tuple arrays in ParseSelector (ethereum#24587) Closes ethereum#24571 * all: use T.TempDir to create temporary test directories (ethereum#24633) This commit replaces ioutil.TempDir with t.TempDir in tests. The directory created by t.TempDir is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using ioutil.TempDir had to be removed manually by calling os.RemoveAll, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but t.TempDir handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * les: fix panic in ultralight client sync (ethereum#24641) * log: modify lock defer unlock order in sync handler (ethereum#24667) This modifies the order of Lock() defer Unlock() to follow the more typically used pattern. * build/deb: update Debian control file to remove unencrypted git protocol (ethereum#24676) * core/types: make "miner" optional in Header JSON (ethereum#24666) "miner" is not set for pending block responses in some cases. Fixes ethereum#24632 * cmd: set DefaultGasLimit to 30M (ethereum#24680) * cmd: set DefaultGasLimit to 30M, rem deprec. Flag * cmd: revert flag deprecation * core: fix benchmark panic (ethereum#24657) This PR fixes a few panics in the chain marker benchmarks. The root cause for panic is in chain marker the genesis header/block is not accessible, while it's expected to be obtained in tests. So this PR avoids touching genesis header at all to avoid panic. * abi/base: return error for pending call error (ethereum#24649) If a pending contract call errors, return that error right away rather than ignoring it to allow an error somewhere else. This is helpful for callers to know if perhaps a call failed because of the context deadline being expired. This change mirrors the behavior of non-pending contract calls. * build: add imports for go generate tools (ethereum#24682) This adds a tools.go file to import all command packages used for go:generate. Doing so makes it possible to execute go-based code generators using 'go run', locking in the tool version using go.mod. Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: make txhash blockhash accessible to native tracers (ethereum#24679) * cmd/geth: support bigints for --override.terminaltotaldifficulty (ethereum#24646) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/downloader: remove stale beacon headers as backfilling progresses (ethereum#24670) * eth/downloader: remove stale beacon headers as backfilling progresses * eth/downloader: remove leftover from a previous design * eth/downloader: do partial beacon cleanups if chain is large * eth/downloader: linter != heart * build: upgrade -dlgo version to Go 1.18.1 (ethereum#24689) * build: upgrade -dlgo version to Go 1.18.1 * build: upgrade -dlgo version for macOS to Go 1.18.1 * eth/downloader: resolve local header by hash for beacon sync (ethereum#24691) * eth/downlaoder: resolve local header by hash for beacon sync * eth/downloader: fix error message * eth/downloader: cap the reverse header resolving * eth/downloader: re-enable tests * eth/downloader: add warning logs * go.mod: upgrade btcec and add 'chainhash' module requirement (ethereum#24700) See ethereum#24554 and btcsuite/btcd#1839 This is an attempt to resolve a Go module dependency issue that arises when both 'github.com/btcsuite/btcd/btcec/v2' and the older, non-v2 btcd module are required as dependencies. * trie: remove unused makeHashNode (ethereum#24702) * core/vm: fix typo (ethereum#24714) Was just browsing the code and found this. * eth/downloader: fix typo in downloader.go (ethereum#24704) synchornization -> synchronization * eth/tracers/logger: remove unnecessary comparisons in accessList.equal (ethereum#24663) This change removes extraneous/unnecessary checks for equality when comparing 2 accessList values A and B. Given that we validate that their lengths of A and B are equal, if so and if every element in A is in B, reflexively every element in B is already in A. If that weren't the case and an element g existed in A but not in B, that would mean that there is an extra element and hence a mathematical contradiction. Fixes ethereum#24658 * README.md: update Go min required version to 1.16 (ethereum#24713) * .github: update CODEOWNERS (ethereum#24743) * internal/flags: fix godoc (ethereum#24734) * cmd/faucet: fix genesis flag and improve documentation (ethereum#24735) * cmd/evm: ensure input length is even (ethereum#24721) * cmd/evm: ensure input length is even * cmd/evm: minor nit + lintfix Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo (ethereum#24731) * mobile: fix receipt encoding to json (ethereum#24701) * p2p: fix type of DiscSubprotocolError (ethereum#24747) It was 'int' accidentally, should be DiscReason instead. * all: use 'embed' instead of go-bindata (ethereum#24744) * cmd/geth, core/state/snapshot: fix flaw in dangling-storage check + inspect difflayers (ethereum#24677) This PR fixes the flaw that @rjl493456442 found in https://github.com/ethereum/go-ethereum/pull/#issuecomment-1093817551 , namely, that the snapshot iterator uses the combined (disk + difflayers) 'view', wheres the raw iterator uses only the disk 'view'. This PR instead splits up the work: one phase is iterating the disk layer data, another phase is loading the journalled difflayers and performing the same check there. * cmd/*: refactor get flag value (ethereum#24761) * consensus/ethash: fix typos in var names (ethereum#24745) * internal/ethapi: add db operations to api (ethereum#24739) Adds `debug_dbGet` method to rpc api * core/types: fix unhandled errors in TestTransactionCoding (ethereum#24692) * cmd/utils: utilize beacon wrapper in makechain (ethereum#24620) * cmd/utils: utilize beacon wrapper in makechain * cmd/utils: fix fake-pow to also be wrapped in beacon * consensus/misc: correct error message * all: use common.FileExist for checking file existence (ethereum#24748) * ethclient/gethclient: return storage proofs in GetProof (ethereum#24697) Storage proofs were being unmarshalled from the RPC form to the go struct, but were not being included in the final returned struct. * eth/filters: remove unused struct fields (ethereum#24782) * cmd/clef: fixups to the python clef poc (ethereum#24440) This PR fixes up the example python clef wrapper. The poc is intended to demonstrate how to wite a UI for clef, and had severely bitrotted. With these changes, it "works" in the sense that all the built-in tests triggers the intended python callbacks (no errors about method not found). It does not "work" in the sense that the wrapper can be used as an actual UI. It will auto-reject any signing requests, for example. * cmd/evm: make evm t8n handle post-merge transitions (ethereum#24546) This adds the ability to run --state.fork=Merged, and have post-merge rules apply. When doing so, it also requires the input env to contain currentRandom, and enforces the currentDifficulty to be omitted or zero. * cmd: group network and db path flags together (ethereum#24698) This PR groups all built-in network flags together and list them in the command as a whole. And all database path flags(datadir, ancient) are also grouped, since usually these two are used together. * accounts: fix typo in comments (ethereum#24805) * docker: speed up docker image build (ethereum#24796) This PR improves the docker build speed for repeated builds where go.mod and go.sum do no change, by placing the downloaded dependencies in a lower layer * cmd/utils: double limit on free-disk monitor (ethereum#24781) This PR doubles the limit on which to trigger automatic shutdown, and also changes the timer to run once every 30s instead of 60s. * build: fix formatted logs (ethereum#24807) Changed `log.Fatal` to `log.Fatalf()` as it has a parameter... * build: ppa build for jammy (ubuntu 22.04) * graphql: add rawReceipt field to transaction type (ethereum#24738) * graphql: add tx receiptsRLP field * use MarshalBinary Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> * update schema Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> * rename to rawReceipt * indent fix Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> * eth/filters: fix code comment (ethereum#24799) * cmd/geth: fix init genesis for dev (ethereum#24693) * cmd/geth: fix init genesis for dev * use ancient flag for init genesis cmd * cmd, eth: fix required blocks regression * core: fix WriteBlockAndSetHead documentation (ethereum#24818) * core: recover state when beacon sets canonical head if it's missing (ethereum#24613) * core: recover the state in SetChainHead if the head state is missing * core: disable test logging * core: address comment from martin * core: improve log level in case state is recovered * core, eth, les, light: rename SetChainHead to SetCanonical * eth/protocols/eth: fix godoc comments (ethereum#24810) Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/filters: remove explicit continue label in filterLogs (ethereum#24795) The loop label can be removed because this 'continue' statement is not in a nested loop. * p2p/simulations: escape mockerType value from request (ethereum#24822) Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/simulations: fix typo in network_test.go (ethereum#24824) * miner: discard interrupted blocks (ethereum#24638) During mining, when a new head arrives and interrupts the block building, the block being built should not be commited (but discarded). Committing the interrupted block introduces unnecessary delay, and possibly causes miner to mine on the previous head, which could result in higher uncle rate. * core/rawdb: untie freezer and ancient chain data (ethereum#24684) Previously freezer has only been used for storing ancient chain data, while obviously it can be used more. This PR unties the chain data and freezer, keep the minimal freezer structure and move all other logic (like incrementally freezing block data) into a separate structure called ChainFreezer. This PR also extends the database interface by adding a new ancient store function AncientDatadir which can return the root directory of ancient store. The ancient root directory can be used when we want to open some other ancient-stores (e.g. reverse diff freezer). * core/vm: implement EIP-3855: PUSH0 instruction (ethereum#24039) * core/vm: Implement PUSH0 * Move PUSH0 to enable3855 * Add method doc * eth/fetcher: avoid hang in tests (partial fix for ethereum#23331) (ethereum#23351) * eth/fetcher: fix test to avoid hanging. Partial fix for ethereum#23331 * eth/filters: avoid dangling goroutines * eth/fetcher: revert closing of proceed * signer/fourbyte: import new signatures (ethereum#22865) * abi: fix checks when all fields are indexed (ethereum#24792) This PR fixes abi checks in the edge case where all arguments are indexed * core/state/snapshot: fix race condition (ethereum#24685) Fixes three race conditions found through fuzzing by David Theodore * all: replace strings.Replace with string.ReplaceAll (ethereum#24835) * internal: drop TestSignCliqueBlock (ethereum#24837) * signer/fourbyte: remove offending signatures (ethereum#24842) * core/vm: update benchmark to use Errorf instead of Sprintf (ethereum#24845) * eth/protocols/snap: sort trienode heal requests by path (ethereum#24779) * sort snap trienode heal requests * eth/protocols/snap: remove debug code * eth/protocols/snap: simplify sort, generate pathsets later * eth/protocols/snap: review concern * eth/protocols/snap: renamings * eth/protocols/snap: add comments in Merge * eth/protocols/snap: remove variable 'last' in Merge * eth/protocols/snap: fix lint flaws in test Co-authored-by: Felix Lange <fjl@twurst.com> * cmd/geth: print info banner for --dev mode (ethereum#24759) Co-authored-by: nedifi <nedifi@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core/vm: clean up some dead functions (ethereum#24851) * core/vm: separate opcode group for 0x20 range (ethereum#24850) * ethclient: add PeerCount method (ethereum#24849) * adding peer count function * Update ethclient.go Co-authored-by: Felix Lange <fjl@twurst.com> * core/vm: optimize Memory.Set32 (ethereum#24847) * core/vm: remove unnecessary memset for Memory.Set32 * core/vm: optimize Memory.Set32 * graphql: fix long literal passed in a variable (ethereum#24864) * core/vm: for tracing, do not report post-op memory * internal/ethapi: add debug_getRawReceipts RPC method (ethereum#24773) Adds a method to retrieve all the binary encoded receipts from a block * params: set ropsten TTD for TheMerge (ethereum#24876) * cmd/utils: add deprecation warning for Rinkeby * core/asm: use strings.Builder and fix godoc issues (ethereum#24861) * all: replace uses of ioutil with io and os (ethereum#24869) * cmd/geth: update vulnerabilities.json testdata (ethereum#24856) * core/vm: reduce overhead in instructions-benchmark (ethereum#24860) * core/vm: reduce footprint of OP benchmark * core/vm: for opBenchmark, add code to detect inputs mutation * Update core/vm/instructions_test.go Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: opBenchmark, stop timer before sanity-test code Co-authored-by: Martin Holst Swende <martin@swende.se> * eth: fix flaky test, don't attach empty slots/proofs (ethereum#24885) * eth/protocols/snap: don't include empty snapshot slot slice This PR fixes the snapshot storage serving handler. In snap protocol the response is capped by the response size. Server can cutdown the response if the accumulated byte size exceeds the local hard limit. It means we can meet a special scenario that there is no storage slot included for a requested account, but we attach the proof for this account by mistake. So in the prover side, when it meets a empty storage response but with a valid proof proves there are some more slots left in the trie, then requestor will reject this response and disconnect with server. In this PR, if there is no storage slot served for the requested account, then no proof should be attached as well. * eth/protocols/snap: loosen restrictions for flaky tests * eth/catalyst: fix flaky test in catalyst * graphql: add raw fields to block and tx (ethereum#24816) * eth/catalyst: set the correct LatestValidHash (ethereum#24855) * eth/catalyst: set the correct LatestValidHash * eth/catalyst: core: return LVH during reorg, rework invalid teminal block * eth/catalyst: nitpicks * cmd/geth: add `db check-state-content` to verify integrity of trie nodes (ethereum#24840) This PR adds db tooling (geth db check-state-content) to verify the integrity of trie nodes. It iterates through the 32-byte key space in the database, which is expected to contain RLP-encoded trie nodes, addressed by hash. * all: use strings.EqualFold for string comparison (ethereum#24890) * all: replace non-trivial uses of package ioutil with os (ethereum#24886) Co-authored-by: Martin Holst Swende <martin@swende.se> * ethdb/remotedb, cmd: add support for remote (readonly) databases (ethereum#24836) * ethdb/remotedb, cmd: add support for remote (readonly) databases * ethdb/remotedb: minor changes * ethdb/remotedb: close the conn * cmd, ethdb: add rpc accessor for ancient data * internal/ethapi: license * ethdb/remotedb: linter fixes * core, eth, internal, rpc: implement final block (ethereum#24282) * eth: core: implement finalized block * eth/catalyst: fix final block * eth/catalyst: update finalized head gauge * internal/jsre/deps: updated web3.js to allow for finalized block * eth/catalyst: make sure only one thread can call fcu * eth/catalyst: nitpicks * eth/catalyst: use plain mutex * eth: nitpicks * eth/catalyst, miner: build the execution payload async (ethereum#24866) * eth/catalyst: build the execution payload async * miner: added comment, added test case * eth/catalyst: miner: move async block production to miner * eth/catalyst, miner: support generate seal block async * miner: rework GetSealingBlockAsync to use a passed channel * miner: apply rjl's diff * eth/catalyst: nitpicks Co-authored-by: Gary Rong <garyrong0905@gmail.com> * eth/tracers/js: goja tracer (ethereum#23773) This adds a JS tracer runtime environment based on the Goja VM. The new runtime replaces the duktape runtime, which will be removed soon. Goja is implemented in Go and is faster for cases where the Go <-> JS transition overhead dominates overall performance. It is faster because duktape is written in C, and the transition cost includes the cost of using cgo. Another reason for using Goja is that go-duktape is not maintained anymore. We expect the performace of JS tracing to be at least as good or better with this change. * params: update goerli bootnodes (ethereum#24900) * params: update goerli bootnodes * params: use ip for enodes * params: fix broken linter * ethdb/remotedb: fix flawed check in Has/HasAncient * core: fix the order of address in queue (ethereum#24907) reverse the order of address in queue * tests: update reference tests (ethereum#24899) * tests: update reference tests * tests: fix flaw in state test execution * f * eth/tracers/js: add memory.length method (ethereum#24887) * eth/catalyst: update implementation to spec (ethereum#24802) * eth/catalyst: return invalid payload attributes error * eth/catalyst: implement LVH as specified, add tests * eth/catalyst: return current block hash not header hash * eth/catalyst: fix test * eth/catalyst: bring error codes in line with spec * core, eth, les, rpc: polish catalyst errors, add context * build/bot: add mac build script (ethereum#24917) * build/bot: remove xctool invocation in macos build script (ethereum#24918) * build/bot: add ppa-build.sh (ethereum#24919) * build/bot: avoid install of python-bzrlib, python-paramiko in PPA build (ethereum#24921) * build/bot: create .ssh directory in ppa-build.sh (ethereum#24922) * core/state/snapshot: detect and clean up dangling storage snapshot in generation (ethereum#24811) * core/state/snapshot: check dangling storages when generating snapshot * core/state/snapshot: polish * core/state/snapshot: wipe the last part of the dangling storages * core/state/snapshot: fix and add tests * core/state/snapshot: fix comment * README: remove mentions of fast sync (ethereum#24656) Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * core, cmd: expose dangling storage detector for wider usage * core/state/snapshot: rename variable * core, ethdb: use global iterators for snapshot generation * core/state/snapshot: polish * cmd, core/state/snapshot: polish * core/state/snapshot: polish * Update core/state/snapshot/generate.go Co-authored-by: Martin Holst Swende <martin@swende.se> * ethdb: extend db test suite and fix memorydb iterator * ethdb/dbtest: rollback changes * ethdb/memorydb: simplify iteration * core/state/snapshot: update dangling counter * core/state/snapshot: release iterators * core/state/snapshot: update metrics * core/state/snapshot: update time metrics * metrics/influxdb: temp solution to present counter meaningfully, remove it * add debug log, revert later * core/state/snapshot: fix iterator panic * all: customized snapshot iterator for backward iteration * core, ethdb: polish * core/state/snapshot: remove debug log * core/state/snapshot: address comments from peter * core/state/snapshot: reopen the iterator at the next position * ethdb, core/state/snapshot: address comment from peter * core/state/snapshot: reopen exhausted iterators Co-authored-by: Tbnoapi <63448616+nuoomnoy02@users.noreply.github.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * accounts/abi: validate fieldnames, fixes ethereum#24930 (ethereum#24932) * common/compiler, cmd/abigen: remove solc/vyper compiler integration * eth/tracers/js: drop duktape engine (ethereum#24934) ethereum#23773 added a JS tracer which uses Goja as its engine. In this PR I remove the previous tracer which used duktape as well as remove the dependencies. This PR also comes with 2 fixes in the Goja tracer and one small behavioural change: I had handled errors in the native Go functions by panicing. My oversight was that Goja only handles panics with a Goja.Value as argument. The difference is panic(goja.Value) allows JS to catch the exception whereas Interrupt(error) doesn't. There was a race in how I handled Stop. Because of 1. some of the methods that simply return nil on error (like memory.slice) now throw an exception. * signer/core: always pad clique header extra data with space for sealer's signature (ethereum#24941) * signer/core: always pad clique header extra data with space for sealer's signature * capitalize comment * go.mod: upgrade to btcsuite/btcd/btcec v2.2.0 (ethereum#24939) This should fully resolve dependency conflict issues in modules that also depend on btcsuite/btcd v0.22.0. * params: update CHTs for Geth 1.10.18 * all: update license headers and AUTHORS from git history (ethereum#24947) * AUTHORS: remove one more duplicate entry (ethereum#24950) * go.mod: upgrade to docker v1.6.2 (ethereum#24956) This upgrade is necessary to silence a Dependabot warning. * params: go-ethereum v1.10.18 stable * params: begin v1.10.19 release cycle * cmd/geth: exit when freezer has legacy receipts (ethereum#24943) In ethereum#24028 we flagged a warning when finding legacy receipts in the freezer. This PR nudges users a bit more strongly by preventing geth from starting in this case until receipts have been migrated. It also adds a flag --ignore-legacy-receipts which when present allows geth to start normally. * cmd/abigen: accept combined-json via stdin (ethereum#24960) * params: set emergency ropsten TTD to 100_000_000_000_000_000_000_000 (ethereum#24975) * core: use less memory during reorgs (ethereum#24616) This PR significantly reduces the memory consumption of a long reorg * cmd/geth: extend traverseRawState command (ethereum#24954) This PR adds node verification into traverseRawState command, so corrupted trie nodes can also be detected. * consensus/clique: fix race condition (ethereum#24957) * consensus/clique: remove race condition * consensus/clique: fix one more signer data race Co-authored-by: Gary Rong <garyrong0905@gmail.com> * eth/catalyst: fix edge case in NewPayload (ethereum#24955) Fixes an issue where we would accept a NewPayload where the grandparent is already post ttd, and the parent still has a Difficulty * contracs/checkpointoracle: fix directives (ethereum#24944) contracts/checkpointoracle: redefine go-generate logic * eth/filters: use buffered channel to avoid goroutine leak (ethereum#24928) * core/beacon: prevent invalid logsBloom length panic (ethereum#24946) * core/beacon: prevent invalid logsBloom length panic * core/beacon: prevent negative baseFeePerGas * Update core/beacon/types.go Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/catalys: go format Co-authored-by: Martin Holst Swende <martin@swende.se> * core: fix canonical hash marker update (ethereum#24996) * core: fix reorg * core: revert change for memory efficiency * core: revert changes * eth/tracers: add support for block overrides in debug_traceCall (ethereum#24871) This PR adds support for block overrides when doing debug_traceCall. - Previously, debug_traceCall against pending erroneously used a common.Hash{} stateroot when looking up the state, meaning that a totally empty state was used -- so it always failed, - With this change, we reject executing debug_traceCall against pending. - And we add ability to override all evm-visible header fields. * tests/fuzzers/bls12381: Add BLST to fuzzing support (ethereum#24249) * tests/fuzzers/bls12381: added blst library * go.mod: added blst dependency * tests/fuzzers/bls12381: stuff * tests/fuzzers/bls12381: added blst to pairing fuzzer * eth/catalyst: return 0x0 on Invalid block on top of pow block (ethereum#25006) * node: make jwt test less dependent on time (ethereum#25016) * consensus/misc: reduce allocations and improve comments in CalcBaseFee (ethereum#24958) * consensus/misc: reduce allocations in CalcBaseFee * consensus/misc: add formulas of CalcBaseFee * go.mod: set go version to 1.17 (ethereum#24926) set go version to 1.17 * go.mod: clean up (ethereum#25017) * core/vm: optimize jumpdest analysis (ethereum#23500) core/vm: optimize PUSH opcode discrimination * tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036) * tests/fuzzers/bls12381: fix blst deserializing * tests/fuzzers/bls12381: fix blst deserializing * cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: introduce trie owner notion (ethereum#24750) * cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/api: use `hexutil.Bytes` for account range method (ethereum#25024) eth/api: use hexutil.Bytes for range at methods * eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020) indentifier -> identifier * trie: move locking into trieDB insert method (ethereum#25030) Move locking into trieDB insert function * params: update ropsten terminal total difficulty block (ethereum#25018) * eth/filters: fix getLogs for pending block (ethereum#24949) * eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation * accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924) * accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627 * accounts, cmd/abigen: resolve name conflicts * ci lint, accounts/abi: remove unused function overloadedArgName Co-authored-by: Gary Rong <garyrong0905@gmail.com> * tests/fuzzers/bls12381: fix blst pairing (ethereum#25037) * tests/fuzzers/bls12381: fix blst pairing * tests/fuzzers/bls12381: only build on gofuzz * tests/fuzzers/bls12381: remove unused code * tests/fuzzers/bls12381: remove unused code * p2p/discover: fix panicky test (ethereum#25038) * accounts: increase parseURL test coverage (ethereum#25033) accounts/url: add test logic what check null string to parseURL() * eth, les, params: log chain config a bit saner (ethereum#24904) Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. This PR converts that original data dump and converts it into a user friendly - alas multiline - log output. * p2p: use errors.Is for error comparison (ethereum#24882) Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: swap out timer metrics to histograms * eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997) Removes engine from any unauthenticated RPC service. * core/types: remove unused field 'td' in Block (ethereum#25010) * core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032) Co-authored-by: Felix Lange <fjl@twurst.com> * core/evm: fix error in comment (ethereum#25040) Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/ethapi: fix typo in comment (ethereum#25056) typo error: keccack256 -> keccak256 * Chore: Minimal gramatical errors (signleton -> singleton) (ethereum#25057) core: fix typos * all: more linters (ethereum#24783) This enables the following linters - typecheck - unused - staticcheck - bidichk - durationcheck - exportloopref - gosec WIth a few exceptions. - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there. - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now. - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention. - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees. * cmd/utils: update --ropsten description (ethereum#25078) * readme,eth: remove references to eth.wiki (ethereum#25086) * cmd/ethkey: use accounts.TextHash (ethereum#25069) * common: improve pretty duration regex (ethereum#25073) * common: improve pretty duration regex * common: improve pretty duration regex * all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087) minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx` * eth: add missing period at end of sentences (ethereum#25058) eth: add missing periods on end of comments * eth: introduce eth67 protocol (ethereum#24093) The new protocol version removes support for GetNodeData. See https://eips.ethereum.org/EIPS/eip-4938 for more information. Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088) * cmd/geth, params: implement Gray Glacier (EIP-5133) * cmd/evm: add gray glacier tests * params: nitpicks * params: fixes * node: add info message when JWT secret is loaded (ethereum#25095) Co-authored-by: Felix Lange <fjl@twurst.com> * params: release Geth v1.10.19 Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: flowerofdream <775654398@qq.com> Co-authored-by: Yong Yang <yangyong775654@163.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Nic Jansma <nic@nicj.net> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: John Adler <adlerjohn@users.noreply.github.com> Co-authored-by: Tatsuya Shimoda <tacoo@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: Tbnoapi <63448616+nuoomnoy02@users.noreply.github.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Tangui Clairet <tangui.clairet@gmail.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: Vaibhaw <kvaibhaw99@gmail.com> Co-authored-by: JoeGruffins <34998433+JoeGruffins@users.noreply.github.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: Emmanuel T Odeke <odeke@ualberta.ca> Co-authored-by: Koosha K <koosha--@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikita Kozhemyakin <enginegl.ec@gmail.com> Co-authored-by: henopied <13500516+henopied@users.noreply.github.com> Co-authored-by: John Difool <johndifoolpi@gmail.com> Co-authored-by: tia-99 <67107070+tia-99@users.noreply.github.com> Co-authored-by: Joshua Gutow <jbgutow@gmail.com> Co-authored-by: hero5512 <lvshuaino@gmail.com> Co-authored-by: nujabes403 <nujabes403@gmail.com> Co-authored-by: EXEC <execvy@gmail.com> Co-authored-by: Evgeny Kolyakov <freaker2k7@users.noreply.github.com> Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> Co-authored-by: milesvant <milesvant@gmail.com> Co-authored-by: ImanSharaf <78227895+ImanSharaf@users.noreply.github.com> Co-authored-by: Mateusz Morusiewicz <11313015+Ruteri@users.noreply.github.com> Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> Co-authored-by: Rachel Franks <nfranks@protonmail.com> Co-authored-by: ||= nil <103940716+nedifi@users.noreply.github.com> Co-authored-by: nedifi <nedifi@users.noreply.github.com> Co-authored-by: Felipe Strozberg <48066928+FelStroz@users.noreply.github.com> Co-authored-by: Qian Bin <cola.tin.com@gmail.com> Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com> Co-authored-by: Afr Schoe <58883403+q9f@users.noreply.github.com> Co-authored-by: zhaochonghe <41711151+zhaochonghe@users.noreply.github.com> Co-authored-by: Eduard S <eduardsanou@posteo.net> Co-authored-by: Austin Roberts <austin.roberts@rivet.cloud> Co-authored-by: Harry Kalodner <harry.kalodner@gmail.com> Co-authored-by: Boqin Qin(秦伯钦) <Bobbqqin@gmail.com> Co-authored-by: Ivan Kuznetsov <me@jeiwan.ru> Co-authored-by: Jonathan Le Brun <42697488+icyfry@users.noreply.github.com> Co-authored-by: Paweł Bylica <chfast@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: lwh <lwhile521@gmail.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Rajaram Gaunker <zimbabao@gmail.com> Co-authored-by: henridf <henri@dubfer.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: Luozhu <70309026+LuozhuZhang@users.noreply.github.com> Co-authored-by: Gustavo Silva <GustavoRSSilva@users.noreply.github.com> Co-authored-by: Ivan Aracki <aracki.ivan@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com>

eth: add missing periods on end of comments

* tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036) * tests/fuzzers/bls12381: fix blst deserializing * tests/fuzzers/bls12381: fix blst deserializing * cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (ethereum#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: introduce trie owner notion (ethereum#24750) * cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/api: use `hexutil.Bytes` for account range method (ethereum#25024) eth/api: use hexutil.Bytes for range at methods * eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020) indentifier -> identifier * trie: move locking into trieDB insert method (ethereum#25030) Move locking into trieDB insert function * params: update ropsten terminal total difficulty block (ethereum#25018) * eth/filters: fix getLogs for pending block (ethereum#24949) * eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation * accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924) * accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627 * accounts, cmd/abigen: resolve name conflicts * ci lint, accounts/abi: remove unused function overloadedArgName Co-authored-by: Gary Rong <garyrong0905@gmail.com> * tests/fuzzers/bls12381: fix blst pairing (ethereum#25037) * tests/fuzzers/bls12381: fix blst pairing * tests/fuzzers/bls12381: only build on gofuzz * tests/fuzzers/bls12381: remove unused code * tests/fuzzers/bls12381: remove unused code * p2p/discover: fix panicky test (ethereum#25038) * accounts: increase parseURL test coverage (ethereum#25033) accounts/url: add test logic what check null string to parseURL() * eth, les, params: log chain config a bit saner (ethereum#24904) Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. This PR converts that original data dump and converts it into a user friendly - alas multiline - log output. * p2p: use errors.Is for error comparison (ethereum#24882) Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: swap out timer metrics to histograms * eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997) Removes engine from any unauthenticated RPC service. * core/types: remove unused field 'td' in Block (ethereum#25010) * core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032) Co-authored-by: Felix Lange <fjl@twurst.com> * core/evm: fix error in comment (ethereum#25040) Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/ethapi: fix typo in comment (ethereum#25056) typo error: keccack256 -> keccak256 * Chore: Minimal gramatical errors (signleton -> singleton) (ethereum#25057) core: fix typos * all: more linters (ethereum#24783) This enables the following linters - typecheck - unused - staticcheck - bidichk - durationcheck - exportloopref - gosec WIth a few exceptions. - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there. - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now. - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention. - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees. * cmd/utils: update --ropsten description (ethereum#25078) * readme,eth: remove references to eth.wiki (ethereum#25086) * cmd/ethkey: use accounts.TextHash (ethereum#25069) * common: improve pretty duration regex (ethereum#25073) * common: improve pretty duration regex * common: improve pretty duration regex * all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087) minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx` * eth: add missing period at end of sentences (ethereum#25058) eth: add missing periods on end of comments * eth: introduce eth67 protocol (ethereum#24093) The new protocol version removes support for GetNodeData. See https://eips.ethereum.org/EIPS/eip-4938 for more information. Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088) * cmd/geth, params: implement Gray Glacier (EIP-5133) * cmd/evm: add gray glacier tests * params: nitpicks * params: fixes * node: add info message when JWT secret is loaded (ethereum#25095) Co-authored-by: Felix Lange <fjl@twurst.com> * params: release Geth v1.10.19 * params: begin v1.10.20 release cycle * internal/ethapi: add comment explaining return of nil instead of error (ethereum#25097) Co-authored-by: Felix Lange <fjl@twurst.com> * tests/fuzzers/rlp: avoid very large input (ethereum#25109) The oss-fuzz engine crashes due to stack overflow decoding a large nested structure into a interface{}. This PR limits the size of the input data, so should avoid such crashes. * node: make jwt tests less time-dependent (ethereum#25120) * cmd/faucet: more verbose message about private posts (ethereum#25129) * cmd/faucet: Add error message for private posts Fixes ethereum#22631 * grammar * internal/ethapi: remove SignAndSendTransaction (ethereum#25111) * cmd/faucet: add sepolia network support (ethereum#25128) cmd/faucet: Add Sepolia network support to faucet * trie: fix size accounting in cleaner (ethereum#25007) Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner * all: remove concept of public/private API definitions (ethereum#25053) * internal/ethapi: rename PublicEthereumAPI to EthereumAPI * eth: rename PublicEthereumAPI to EthereumAPI * internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI * internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI * internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI * internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI * internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI * internal/ethapi: rename PublicDebugAPI to DebugAPI * internal/ethapi: move PrivateDebugAPI methods to DebugAPI * internal/ethapi: rename PublicNetAPI to NetAPI * les: rename PrivateLightServerAPI to LightServerAPI * les: rename PrivateLightAPI to LightAPI * les: rename PrivateDebugAPI to DebugAPI * les: rename PublicDownloaderAPI to DownloaderAPI * eth,les: rename PublicFilterAPI to FilterAPI * eth: rename PublicMinerAPI to MinerAPI * eth: rename PublicDownloaderAPI to DownloaderAPI * eth: move PrivateMinerAPI methods to MinerAPI * eth: rename PrivateAdminAPI to AdminAPI * eth: rename PublicDebugAPI to DebugAPI * eth: move PrivateDebugAPI methods to DebugAPI * node: rename publicAdminAPI to adminAPI * node: move privateAdminAPI methods to adminAPI * node: rename publicWeb3API to web3API * eth,internal/ethapi: sync comments with previous renamings * cmd/geth: drop geth js command (ethereum#25000) * cmd/geth: drop js command * cmd: simplify ipc path determination for attach * Add deprecation warning for js * rm testdata for exec * fix account unlock test cases * Update cmd/geth/consolecmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix Co-authored-by: Martin Holst Swende <martin@swende.se> * README,rpc: remove mention of "shh" RPC API (ethereum#25137) * eth, miner: retrieve mining state from live database (ethereum#25139) * miner: retrieve mining state from live database * eth/catalyst: ignore stale fcu events from cl * core: fix typo in txpool (ethereum#25149) Fix typo in txPool truncateQueue comment * go.mod: upgrade to latest goleveldb (ethereum#25067) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: optimize goja buffer conversion (ethereum#25156) This changes the []byte <-> Uint8Array conversion to use an ArrayBuffer, avoiding inefficient copying of the slice data in Goja. Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix typo (ethereum#25161) * internal/ethapi: always return chain id (ethereum#25166) The error was introduced in PR ethereum#21686, but there is no good reason to enforce sync in this method, and it causes issues with EL/CL integration. * internal/ethapi: add note about eth_chainId compatibility with EIP-695 (ethereum#25168) Co-authored-by: Felix Lange <fjl@twurst.com> * all: remove `public` field from `rpc.API` (ethereum#25059) all: remove public field from rpc.API * cmd: migrate to urfave/cli/v2 (ethereum#24751) This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json * params: set TTD for sepolia testnet (ethereum#25179) * cmd/geth, p2p: add support for custom discovery UDP port (ethereum#24979) This adds a new flag to set the discovery port to be different from the TCP listener port. Co-authored-by: Felix Lange <fjl@twurst.com> * fix: linter warning (ethereum#25192) * core/rawdb: fix typo in comment (ethereum#25191) * core/rawdb: simplify TestDiskSeek to use memorydb (ethereum#25182) * cmd/utils: fix applying bootstrap nodes from config file (ethereum#25174) * internal/ethapi: return chain id for EIP-155 legacy txs (ethereum#25155) * common: increase StorageSize test coverage (ethereum#25188) * consensus/beacon: check that only the latest pow block is valid ttd block (ethereum#25187) * consensus/beacon: check that only the latest pow block is valid ttd block * consensus/beacon: move verification to async function * consensus/beacon: fix verifyTerminalPoWBlock, add test cases * consensus/beacon: cosmetic changes * consensus/beacon: apply karalabe's fixes * build: fix auto-completion scripts and include them in .deb package (ethereum#25195) Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to golangci-lint v1.46.2 (ethereum#25202) This upgrade is required to fix lint issues with urfave/cli/v2, which uses generics when built with Go 1.18 * build/deb: fix auto-completion install paths (ethereum#25204) * params: go-ethereum v1.10.20 stable * params: begin v1.10.21 release cycle * common/prque: fix typo * eth/catalyst: disallow importing blocks via newPayload during snap sync (ethereum#25210) * eth/catalyst: disallow importing blocks via newPayload during snap sync * eth/catalyst: make tests pass by using full sync only * eth/catalysts: make the import delay a bit cleaner * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Replace fmt.Errorf with errors.New in abi argument (ethereum#25181) Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go * all: change format `0x%x` to `%#x` (ethereum#25221) * consensus/beacon: copy td value so we can modify it (ethereum#25230) * consensus/beacon: copy td value so we can modify it * consensus/beacon: copy td value so we can modify it * core: allow external code to set the block validator for malicious tests (ethereum#25119) * core: don't validate state * core: allow external validator * core: revert * core: comments * Update blockchain_reader.go * core: move SetValidator to blockchain.go * core: rename method * core: apply ttd override to uninitialized db (ethereum#25136) * core: apply ttd override to genesis block * core: apply overrides properly * signer/core/apitypes: support primitive types int96/uint96 (ethereum#25105) I have a EIP712 typehash using uint96, but it's currently not supported by go-ethereum. This change fixes it. * cmd/geth, cmd/devp2p: fix some cli parsing issues (ethereum#25234) * cmd/geth: add some missing argument count checks * internal/flags: skip cmds with no action func in MigrateGlobalFlags * internal/flags: add Merge * cmd/devp2p: re-add listener config flags in discv4 commands * core: allow external processor (ethereum#25233) * consensus/beacon: verify timestamp is greater than parent timestamp (ethereum#25236) * go.mod: updated logfmt dependency (ethereum#25231) This fixes an issue in abigen tests with go 1.17. * internal/ethapi: add basefee to block overrides (ethereum#25219) * trie: fix typo in comment (ethereum#25241) paralallel -> parallel * core/types: fix typo in comment (ethereum#25249) * internal/ethapi: fix chain ID check to return all non-zero IDs (ethereum#25244) * rpc: add graceful shutdown timeout for HTTP server (ethereum#25258) This change ensures the HTTP server will always terminate within at most 5s, even when all connections are busy and do not become idle. Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/discover: fix typos in comments (ethereum#25272) * build: upgrade -dlgo version to Go 1.18.3 * core, eth: pre-allocate map in storage copy (ethereum#25279) * eth/tracers: add initial revertReasonTracer tracer (ethereum#25265) Adds a native tracer that returns that in case of failure returns the error message or the revert reason of a transaction. Co-authored-by: Martin Holst Swende <martin@swende.se> * params: enable DNS discovery on Sepolia too * internal/build: add a timestamp to the tar archive folder * build: upgrade -dlgo version to Go 1.18.4 * accounts/abi: fix typo in comment (ethereum#25271) * accounts/abi/bind/backends: return hash of new blocks (ethereum#25163) Co-authored-by: Jens <jmw.1906@gmx.de> * all: remove version field from rpc.API * internal/ethapi: error if tx args includes chain id that doesn't match local (ethereum#25157) * internal/ethapi: error if tx args includes chain id that doesn't match local * internal/ethapi: simplify code a bit Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core: remove lock in BlockChain.ExportN (ethereum#25254) * Remove locking in (*BlockChain).ExportN Since ExportN is read-only, it shouldn't need the lock. (?) * Add hash check to detect reorgs during export. * fix check order * Update blockchain.go * Update blockchain.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: prevent negative fee during RPC calls (ethereum#25214) During RPC calls such as eth_call and eth_estimateGas, st.evm.Config.NoBaseFee is set which allows the gas price to be below the base fee. This results the tip being negative, and balance being subtracted from the coinbase instead of added to it, which results in a potentially negative coinbase balance interestingly. This can't happen during normal chain processing as outside of RPC calls the gas price is required to be at least the base fee, as NoBaseFee is false. This change prevents this behavior by disabling fee payment when the fee is not set. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core, les, eth: port snap sync changes (ethereum#24898) core, eth, les, trie: rework snap sync * tests: only activate merge on london rules (ethereum#25239) * trie: fix 'gosimple' lint issue (ethereum#25309) * p2p/discover: apply netrestrict in discv5 response handler (ethereum#25304) * cmd/geth: remove redundant 0x in dbGet/dbDelete (ethereum#25315) * accounts/abi: substitude arg%d to the range keyword (ethereum#25307) * accounts/abi: substitude arg%d to the range keyword * support more keywords * review feedback * params: Add Shanghai and Cancun blocks (ethereum#25305) * params: Add Shangai and Cancun blocks * fix copy/paste error Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo in Shanghai name Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/puppeth: remove support for exporting non-Geth genesis configurations (ethereum#25329) * cmd/puppeth: remove support for exporting non-Geth genesis configurations * remove unused function * params: set goerli TTD to 10_790_000 (ethereum#25324) * signer/core: add canonical TypedData hashing methods (ethereum#25283) * params: set sepolia mergeNetsplitBlock to 1735371 (ethereum#25372) * cmd/geth: eth/catalyst: enable authrpc by default (ethereum#25152) * cmd/geth: eth/catalyst: enable authrpc by default * eth/catalyst: rename catalyst -> Engine API in logs * eth/catalyst: don't panic * deps: update goleveldb * eth/catalyst: better warning for ttd not configured (ethereum#25394) * cmd: use flags.Merge for grouping flags (ethereum#25392) * consensus/beacon: fix typo in comment (ethereum#25391) * p2p/netutil: minor code cosmetic Signed-off-by: Abirdcfly <fp544037857@gmail.com> * eth, internal, light: fix error string capitalization (ethereum#25364) * light: fix differTries err message in tests (ethereum#25358) * all: add whitespace linter (ethereum#25312) * golangci: typo Signed-off-by: Delweng <delweng@gmail.com> * golangci: add whietspace Signed-off-by: Delweng <delweng@gmail.com> * *: rm whitesapce using golangci-lint Signed-off-by: Delweng <delweng@gmail.com> * cmd/puppeth: revert accidental resurrection Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers/js: fix capitalization in tests * eth: support bubbling up bad blocks from sync to the engine API (ethereum#25190) * eth: support bubbling up bad blocks from sync to the engine API * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Update eth/catalyst/api.go * eth/catalyst: when forgetting bad hashes, also forget descendants * eth/catalyst: minor bad block tweaks for resilience Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * params: change Merge config to print simpler message This fixes ethereum#25366 * core: eth: rpc: implement safe rpc block (ethereum#25165) * core: eth: rpc: implement safe rpc block * core: fix setHead, panics * go.mod: downgrade leveldb (ethereum#25413) * params: go-ethereum v1.10.21 stable * params: begin v1.10.22 release cycle * core, trie, eth, cmd: rework preimage store (ethereum#25287) * core, trie, eth, cmd: rework preimage store * trie: address comment * eth/catalyst: fix NewPayload warn log when dropping due to snap sync * node: set JWT expiry to 60 seconds (ethereum#25416) * node: set JWT expiry to 60 seconds * node: rename var * eth/catalyst: return syncing not accepted (ethereum#25414) * eth/catalyst: return syncing not accepted * eth/catalyst: fix test * eth/catalyst: return 0x0 if latestvalid is pow block (ethereum#25423) * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <peterke@gmail.com> * ethereum, ethclient: add FeeHistory support (ethereum#25403) Co-authored-by: Felix Lange <fjl@twurst.com> * all: use AbsTime.Add instead of conversion (ethereum#25417) * cm/puppeth: fix crash when of ethstats specifier doesn't contain `:` (ethereum#25405) Signed-off-by: Delweng <delweng@gmail.com> * eth: fix typo in comment (ethereum#25327) * common/compiler: json unmarshalling error checks (ethereum#25449) complier/solidity:add json.Unmarshal err check * cmd, core, eth, les, params: add merge-passed chain config (ethereum#24538) * cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges * eth: fix typo in catalyst api (ethereum#25460) eth: fix typo * eth/gasprice/feehistory: support finalized block (ethereum#25442) * build: upgrade -dlgo version to Go 1.18.5 * consensus/ethash: remove temp files created during DAG generation (ethereum#25381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating. * cmd/devp2p/internal/ethtest: update tests for eth/67 (ethereum#25306) * node, rpc: add ReadHeaderTimeout config option (ethereum#25338) This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments. * core/types: fix typo in comment (ethereum#25359) * core: preallocate batch size in bloomIndexer (ethereum#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. * internal/ethapi: don't estimate gas if no limit provided in eth_createAccessList (ethereum#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate. * graphql: embed *Resolver instead of backend interface (ethereum#25468) This creates some infrastructure to share resources between graphql API objects. * node: remove noop path.Join (ethereum#25475) Signed-off-by: Delweng <delweng@gmail.com> * core, trie: rework trie committer (ethereum#25320) * all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test * core: use TryGetAccount to read what TryUpdateAccount has written (ethereum#25458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * cmd, core, ethdb, node: move chain freezer one folder deeper (ethereum#25487) * cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue * eth/downloader: fix log errors of queue_test.go (ethereum#25494) * core: fix uncle creation in TestFastVsFullChains (ethereum#25476) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: formatted error nit (ethereum#25499) * eth/tracers: add onlyTopCall option to callTracer (ethereum#25430) This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See ethereum#25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about. * all: cleanup the APIs for initializing genesis (ethereum#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment * signer/rules: register clef api properly when rules are used (ethereum#25455) signer/rules: register clef api properly when rules are used, fixes ethereum#25298 * core: remove unused bc ChainContext in applyTransaction * build: add static linking support (ethereum#25492) This adds support for building statically-linked executables using ci.go. Static linking is enabled by default in Docker builds, making it possible to use the geth executable in any Docker image, regardless of the Linux distribution the Dockerfile is based on. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: display name in "method/event not found" error (ethereum#25512) * internal/ethapi: rework setDefaults for tx args so fee logic is separate (ethereum#25197) Co-authored-by: bobpkr <bob.p@krustuniverse.com> * core/genesis: remove calaverasAllocData (ethereum#25516) core/genesis: calaverasAllocData no longer used * params: set ttdpassed on goerli (ethereum#25519) * params: set mainnet terminal total difficulty for the merge (ethereum#25528) * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * core, trie: flush preimages to db on blockchain close (ethereum#25533) * core, trie: flush preimages to db on database close Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * rename Close to CommitPreimages for clarity * core, trie: nitpick fixes Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core/state, trie, light: add a TryDeleteAccount method (ethereum#25531) * core/state, trie, light: Add a DeleteAccount method * review feedback * Update database.go * pr triage feedback Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: make tx journal check and open atomic (ethereum#25530) * core: reduce system call about `os` * avoid deprecated method * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * Release Geth v1.10.24 * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * params: release Geth v1.10.25 Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: lwh <lwhile521@gmail.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Rajaram Gaunker <zimbabao@gmail.com> Co-authored-by: henridf <henri@dubfer.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: Luozhu <70309026+LuozhuZhang@users.noreply.github.com> Co-authored-by: Gustavo Silva <GustavoRSSilva@users.noreply.github.com> Co-authored-by: Ivan Aracki <aracki.ivan@gmail.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: Kosuke Taniguchi <73885532+TaniguchiKosuke@users.noreply.github.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: willian.eth <willian@ufpa.br> Co-authored-by: zeim839 <50573884+zeim839@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Ruohui Wang <nomaru@outlook.com> Co-authored-by: Andre Patta <andre_luis@outlook.com> Co-authored-by: スパイク <1311798+spkjp@users.noreply.github.com> Co-authored-by: Brion <4777457+cifer76@users.noreply.github.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Philip Fan <fanwengang@hotmail.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: Jens <jmw.1906@gmx.de> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: henridf <henridf@gmail.com> Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Ha ĐANG <dvietha@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Eval EXEC <execvy@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Rithwik Babu <rithwikbabu2020@gmail.com> Co-authored-by: Henry <101552941+henry-0@users.noreply.github.com> Co-authored-by: Manoj Kumar <mnjkmr398@gmail.com> Co-authored-by: Tristan-Wilson <87238672+Tristan-Wilson@users.noreply.github.com> Co-authored-by: yong <33920876+yzhaoyu@users.noreply.github.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: ycyraum <ycyraum@fastmail.com> Co-authored-by: 0xe3b0c4 <110295932+0xe3b0c4@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: bobpkr <bob.p@krustuniverse.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com>

* params: begin v1.10.19 release cycle * cmd/geth: exit when freezer has legacy receipts (ethereum#24943) In ethereum#24028 we flagged a warning when finding legacy receipts in the freezer. This PR nudges users a bit more strongly by preventing geth from starting in this case until receipts have been migrated. It also adds a flag --ignore-legacy-receipts which when present allows geth to start normally. * cmd/abigen: accept combined-json via stdin (ethereum#24960) * params: set emergency ropsten TTD to 100_000_000_000_000_000_000_000 (ethereum#24975) * core: use less memory during reorgs (ethereum#24616) This PR significantly reduces the memory consumption of a long reorg * cmd/geth: extend traverseRawState command (ethereum#24954) This PR adds node verification into traverseRawState command, so corrupted trie nodes can also be detected. * consensus/clique: fix race condition (ethereum#24957) * consensus/clique: remove race condition * consensus/clique: fix one more signer data race Co-authored-by: Gary Rong <garyrong0905@gmail.com> * eth/catalyst: fix edge case in NewPayload (ethereum#24955) Fixes an issue where we would accept a NewPayload where the grandparent is already post ttd, and the parent still has a Difficulty * contracs/checkpointoracle: fix directives (ethereum#24944) contracts/checkpointoracle: redefine go-generate logic * eth/filters: use buffered channel to avoid goroutine leak (ethereum#24928) * core/beacon: prevent invalid logsBloom length panic (ethereum#24946) * core/beacon: prevent invalid logsBloom length panic * core/beacon: prevent negative baseFeePerGas * Update core/beacon/types.go Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/catalys: go format Co-authored-by: Martin Holst Swende <martin@swende.se> * core: fix canonical hash marker update (ethereum#24996) * core: fix reorg * core: revert change for memory efficiency * core: revert changes * eth/tracers: add support for block overrides in debug_traceCall (ethereum#24871) This PR adds support for block overrides when doing debug_traceCall. - Previously, debug_traceCall against pending erroneously used a common.Hash{} stateroot when looking up the state, meaning that a totally empty state was used -- so it always failed, - With this change, we reject executing debug_traceCall against pending. - And we add ability to override all evm-visible header fields. * tests/fuzzers/bls12381: Add BLST to fuzzing support (ethereum#24249) * tests/fuzzers/bls12381: added blst library * go.mod: added blst dependency * tests/fuzzers/bls12381: stuff * tests/fuzzers/bls12381: added blst to pairing fuzzer * eth/catalyst: return 0x0 on Invalid block on top of pow block (ethereum#25006) * node: make jwt test less dependent on time (ethereum#25016) * consensus/misc: reduce allocations and improve comments in CalcBaseFee (ethereum#24958) * consensus/misc: reduce allocations in CalcBaseFee * consensus/misc: add formulas of CalcBaseFee * go.mod: set go version to 1.17 (ethereum#24926) set go version to 1.17 * go.mod: clean up (ethereum#25017) * core/vm: optimize jumpdest analysis (ethereum#23500) core/vm: optimize PUSH opcode discrimination * tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036) * tests/fuzzers/bls12381: fix blst deserializing * tests/fuzzers/bls12381: fix blst deserializing * cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (ethereum#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: introduce trie owner notion (ethereum#24750) * cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/api: use `hexutil.Bytes` for account range method (ethereum#25024) eth/api: use hexutil.Bytes for range at methods * eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020) indentifier -> identifier * trie: move locking into trieDB insert method (ethereum#25030) Move locking into trieDB insert function * params: update ropsten terminal total difficulty block (ethereum#25018) * eth/filters: fix getLogs for pending block (ethereum#24949) * eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation * accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924) * accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627 * accounts, cmd/abigen: resolve name conflicts * ci lint, accounts/abi: remove unused function overloadedArgName Co-authored-by: Gary Rong <garyrong0905@gmail.com> * tests/fuzzers/bls12381: fix blst pairing (ethereum#25037) * tests/fuzzers/bls12381: fix blst pairing * tests/fuzzers/bls12381: only build on gofuzz * tests/fuzzers/bls12381: remove unused code * tests/fuzzers/bls12381: remove unused code * p2p/discover: fix panicky test (ethereum#25038) * accounts: increase parseURL test coverage (ethereum#25033) accounts/url: add test logic what check null string to parseURL() * eth, les, params: log chain config a bit saner (ethereum#24904) Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. This PR converts that original data dump and converts it into a user friendly - alas multiline - log output. * p2p: use errors.Is for error comparison (ethereum#24882) Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: swap out timer metrics to histograms * eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997) Removes engine from any unauthenticated RPC service. * core/types: remove unused field 'td' in Block (ethereum#25010) * core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032) Co-authored-by: Felix Lange <fjl@twurst.com> * core/evm: fix error in comment (ethereum#25040) Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/ethapi: fix typo in comment (ethereum#25056) typo error: keccack256 -> keccak256 * Chore: Minimal gramatical errors (signleton -> singleton) (ethereum#25057) core: fix typos * all: more linters (ethereum#24783) This enables the following linters - typecheck - unused - staticcheck - bidichk - durationcheck - exportloopref - gosec WIth a few exceptions. - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there. - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now. - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention. - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees. * cmd/utils: update --ropsten description (ethereum#25078) * readme,eth: remove references to eth.wiki (ethereum#25086) * cmd/ethkey: use accounts.TextHash (ethereum#25069) * common: improve pretty duration regex (ethereum#25073) * common: improve pretty duration regex * common: improve pretty duration regex * all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087) minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx` * eth: add missing period at end of sentences (ethereum#25058) eth: add missing periods on end of comments * eth: introduce eth67 protocol (ethereum#24093) The new protocol version removes support for GetNodeData. See https://eips.ethereum.org/EIPS/eip-4938 for more information. Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088) * cmd/geth, params: implement Gray Glacier (EIP-5133) * cmd/evm: add gray glacier tests * params: nitpicks * params: fixes * node: add info message when JWT secret is loaded (ethereum#25095) Co-authored-by: Felix Lange <fjl@twurst.com> * params: release Geth v1.10.19 * params: begin v1.10.20 release cycle * internal/ethapi: add comment explaining return of nil instead of error (ethereum#25097) Co-authored-by: Felix Lange <fjl@twurst.com> * tests/fuzzers/rlp: avoid very large input (ethereum#25109) The oss-fuzz engine crashes due to stack overflow decoding a large nested structure into a interface{}. This PR limits the size of the input data, so should avoid such crashes. * node: make jwt tests less time-dependent (ethereum#25120) * cmd/faucet: more verbose message about private posts (ethereum#25129) * cmd/faucet: Add error message for private posts Fixes ethereum#22631 * grammar * internal/ethapi: remove SignAndSendTransaction (ethereum#25111) * cmd/faucet: add sepolia network support (ethereum#25128) cmd/faucet: Add Sepolia network support to faucet * trie: fix size accounting in cleaner (ethereum#25007) Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner * all: remove concept of public/private API definitions (ethereum#25053) * internal/ethapi: rename PublicEthereumAPI to EthereumAPI * eth: rename PublicEthereumAPI to EthereumAPI * internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI * internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI * internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI * internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI * internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI * internal/ethapi: rename PublicDebugAPI to DebugAPI * internal/ethapi: move PrivateDebugAPI methods to DebugAPI * internal/ethapi: rename PublicNetAPI to NetAPI * les: rename PrivateLightServerAPI to LightServerAPI * les: rename PrivateLightAPI to LightAPI * les: rename PrivateDebugAPI to DebugAPI * les: rename PublicDownloaderAPI to DownloaderAPI * eth,les: rename PublicFilterAPI to FilterAPI * eth: rename PublicMinerAPI to MinerAPI * eth: rename PublicDownloaderAPI to DownloaderAPI * eth: move PrivateMinerAPI methods to MinerAPI * eth: rename PrivateAdminAPI to AdminAPI * eth: rename PublicDebugAPI to DebugAPI * eth: move PrivateDebugAPI methods to DebugAPI * node: rename publicAdminAPI to adminAPI * node: move privateAdminAPI methods to adminAPI * node: rename publicWeb3API to web3API * eth,internal/ethapi: sync comments with previous renamings * cmd/geth: drop geth js command (ethereum#25000) * cmd/geth: drop js command * cmd: simplify ipc path determination for attach * Add deprecation warning for js * rm testdata for exec * fix account unlock test cases * Update cmd/geth/consolecmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix Co-authored-by: Martin Holst Swende <martin@swende.se> * README,rpc: remove mention of "shh" RPC API (ethereum#25137) * eth, miner: retrieve mining state from live database (ethereum#25139) * miner: retrieve mining state from live database * eth/catalyst: ignore stale fcu events from cl * core: fix typo in txpool (ethereum#25149) Fix typo in txPool truncateQueue comment * go.mod: upgrade to latest goleveldb (ethereum#25067) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: optimize goja buffer conversion (ethereum#25156) This changes the []byte <-> Uint8Array conversion to use an ArrayBuffer, avoiding inefficient copying of the slice data in Goja. Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix typo (ethereum#25161) * internal/ethapi: always return chain id (ethereum#25166) The error was introduced in PR ethereum#21686, but there is no good reason to enforce sync in this method, and it causes issues with EL/CL integration. * internal/ethapi: add note about eth_chainId compatibility with EIP-695 (ethereum#25168) Co-authored-by: Felix Lange <fjl@twurst.com> * all: remove `public` field from `rpc.API` (ethereum#25059) all: remove public field from rpc.API * all: remove version field from rpc.API * cmd: migrate to urfave/cli/v2 (ethereum#24751) This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json * params: set TTD for sepolia testnet (ethereum#25179) * cmd/geth, p2p: add support for custom discovery UDP port (ethereum#24979) This adds a new flag to set the discovery port to be different from the TCP listener port. Co-authored-by: Felix Lange <fjl@twurst.com> * fix: linter warning (ethereum#25192) * core/rawdb: fix typo in comment (ethereum#25191) * core/rawdb: simplify TestDiskSeek to use memorydb (ethereum#25182) * cmd/utils: fix applying bootstrap nodes from config file (ethereum#25174) * internal/ethapi: return chain id for EIP-155 legacy txs (ethereum#25155) * common: increase StorageSize test coverage (ethereum#25188) * consensus/beacon: check that only the latest pow block is valid ttd block (ethereum#25187) * consensus/beacon: check that only the latest pow block is valid ttd block * consensus/beacon: move verification to async function * consensus/beacon: fix verifyTerminalPoWBlock, add test cases * consensus/beacon: cosmetic changes * consensus/beacon: apply karalabe's fixes * build: fix auto-completion scripts and include them in .deb package (ethereum#25195) Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to golangci-lint v1.46.2 (ethereum#25202) This upgrade is required to fix lint issues with urfave/cli/v2, which uses generics when built with Go 1.18 * build/deb: fix auto-completion install paths (ethereum#25204) * params: go-ethereum v1.10.20 stable * params: begin v1.10.21 release cycle * common/prque: fix typo * eth/catalyst: disallow importing blocks via newPayload during snap sync (ethereum#25210) * eth/catalyst: disallow importing blocks via newPayload during snap sync * eth/catalyst: make tests pass by using full sync only * eth/catalysts: make the import delay a bit cleaner * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Replace fmt.Errorf with errors.New in abi argument (ethereum#25181) Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go * all: change format `0x%x` to `%#x` (ethereum#25221) * consensus/beacon: copy td value so we can modify it (ethereum#25230) * consensus/beacon: copy td value so we can modify it * consensus/beacon: copy td value so we can modify it * core: allow external code to set the block validator for malicious tests (ethereum#25119) * core: don't validate state * core: allow external validator * core: revert * core: comments * Update blockchain_reader.go * core: move SetValidator to blockchain.go * core: rename method * core: apply ttd override to uninitialized db (ethereum#25136) * core: apply ttd override to genesis block * core: apply overrides properly * signer/core/apitypes: support primitive types int96/uint96 (ethereum#25105) I have a EIP712 typehash using uint96, but it's currently not supported by go-ethereum. This change fixes it. * cmd/geth, cmd/devp2p: fix some cli parsing issues (ethereum#25234) * cmd/geth: add some missing argument count checks * internal/flags: skip cmds with no action func in MigrateGlobalFlags * internal/flags: add Merge * cmd/devp2p: re-add listener config flags in discv4 commands * core: allow external processor (ethereum#25233) * consensus/beacon: verify timestamp is greater than parent timestamp (ethereum#25236) * go.mod: updated logfmt dependency (ethereum#25231) This fixes an issue in abigen tests with go 1.17. * internal/ethapi: add basefee to block overrides (ethereum#25219) * build: upgrade -dlgo version to Go 1.18.3 * trie: fix typo in comment (ethereum#25241) paralallel -> parallel * core/types: fix typo in comment (ethereum#25249) * internal/ethapi: fix chain ID check to return all non-zero IDs (ethereum#25244) * rpc: add graceful shutdown timeout for HTTP server (ethereum#25258) This change ensures the HTTP server will always terminate within at most 5s, even when all connections are busy and do not become idle. Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/discover: fix typos in comments (ethereum#25272) * core, eth: pre-allocate map in storage copy (ethereum#25279) * eth/tracers: add initial revertReasonTracer tracer (ethereum#25265) Adds a native tracer that returns that in case of failure returns the error message or the revert reason of a transaction. Co-authored-by: Martin Holst Swende <martin@swende.se> * params: enable DNS discovery on Sepolia too * internal/build: add a timestamp to the tar archive folder * build: upgrade -dlgo version to Go 1.18.4 * accounts/abi: fix typo in comment (ethereum#25271) * accounts/abi/bind/backends: return hash of new blocks (ethereum#25163) Co-authored-by: Jens <jmw.1906@gmx.de> * internal/ethapi: error if tx args includes chain id that doesn't match local (ethereum#25157) * internal/ethapi: error if tx args includes chain id that doesn't match local * internal/ethapi: simplify code a bit Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core: remove lock in BlockChain.ExportN (ethereum#25254) * Remove locking in (*BlockChain).ExportN Since ExportN is read-only, it shouldn't need the lock. (?) * Add hash check to detect reorgs during export. * fix check order * Update blockchain.go * Update blockchain.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: prevent negative fee during RPC calls (ethereum#25214) During RPC calls such as eth_call and eth_estimateGas, st.evm.Config.NoBaseFee is set which allows the gas price to be below the base fee. This results the tip being negative, and balance being subtracted from the coinbase instead of added to it, which results in a potentially negative coinbase balance interestingly. This can't happen during normal chain processing as outside of RPC calls the gas price is required to be at least the base fee, as NoBaseFee is false. This change prevents this behavior by disabling fee payment when the fee is not set. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core, les, eth: port snap sync changes (ethereum#24898) core, eth, les, trie: rework snap sync * tests: only activate merge on london rules (ethereum#25239) * trie: fix 'gosimple' lint issue (ethereum#25309) * p2p/discover: apply netrestrict in discv5 response handler (ethereum#25304) * cmd/geth: remove redundant 0x in dbGet/dbDelete (ethereum#25315) * accounts/abi: substitude arg%d to the range keyword (ethereum#25307) * accounts/abi: substitude arg%d to the range keyword * support more keywords * review feedback * params: Add Shanghai and Cancun blocks (ethereum#25305) * params: Add Shangai and Cancun blocks * fix copy/paste error Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo in Shanghai name Co-authored-by: Martin Holst Swende <martin@swende.se> * params: change Merge config to print simpler message This fixes ethereum#25366 * cmd/puppeth: remove support for exporting non-Geth genesis configurations (ethereum#25329) * cmd/puppeth: remove support for exporting non-Geth genesis configurations * remove unused function * params: set goerli TTD to 10_790_000 (ethereum#25324) * signer/core: add canonical TypedData hashing methods (ethereum#25283) * deps: update goleveldb * params: set sepolia mergeNetsplitBlock to 1735371 (ethereum#25372) * cmd/geth: eth/catalyst: enable authrpc by default (ethereum#25152) * cmd/geth: eth/catalyst: enable authrpc by default * eth/catalyst: rename catalyst -> Engine API in logs * eth/catalyst: don't panic * eth/catalyst: better warning for ttd not configured (ethereum#25394) * cmd: use flags.Merge for grouping flags (ethereum#25392) * consensus/beacon: fix typo in comment (ethereum#25391) * p2p/netutil: minor code cosmetic Signed-off-by: Abirdcfly <fp544037857@gmail.com> * eth, internal, light: fix error string capitalization (ethereum#25364) * light: fix differTries err message in tests (ethereum#25358) * all: add whitespace linter (ethereum#25312) * golangci: typo Signed-off-by: Delweng <delweng@gmail.com> * golangci: add whietspace Signed-off-by: Delweng <delweng@gmail.com> * *: rm whitesapce using golangci-lint Signed-off-by: Delweng <delweng@gmail.com> * cmd/puppeth: revert accidental resurrection Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers/js: fix capitalization in tests * eth: support bubbling up bad blocks from sync to the engine API (ethereum#25190) * eth: support bubbling up bad blocks from sync to the engine API * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Update eth/catalyst/api.go * eth/catalyst: when forgetting bad hashes, also forget descendants * eth/catalyst: minor bad block tweaks for resilience Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * core: eth: rpc: implement safe rpc block (ethereum#25165) * core: eth: rpc: implement safe rpc block * core: fix setHead, panics * go.mod: downgrade leveldb (ethereum#25413) * params: go-ethereum v1.10.21 stable * params: begin v1.10.22 release cycle * core, trie, eth, cmd: rework preimage store (ethereum#25287) * core, trie, eth, cmd: rework preimage store * trie: address comment * eth/catalyst: fix NewPayload warn log when dropping due to snap sync * node: set JWT expiry to 60 seconds (ethereum#25416) * node: set JWT expiry to 60 seconds * node: rename var * eth/catalyst: return syncing not accepted (ethereum#25414) * eth/catalyst: return syncing not accepted * eth/catalyst: fix test * eth/catalyst: return 0x0 if latestvalid is pow block (ethereum#25423) * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <peterke@gmail.com> * ethereum, ethclient: add FeeHistory support (ethereum#25403) Co-authored-by: Felix Lange <fjl@twurst.com> * all: use AbsTime.Add instead of conversion (ethereum#25417) * cm/puppeth: fix crash when of ethstats specifier doesn't contain `:` (ethereum#25405) Signed-off-by: Delweng <delweng@gmail.com> * eth: fix typo in comment (ethereum#25327) * common/compiler: json unmarshalling error checks (ethereum#25449) complier/solidity:add json.Unmarshal err check * cmd, core, eth, les, params: add merge-passed chain config (ethereum#24538) * cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges * eth: fix typo in catalyst api (ethereum#25460) eth: fix typo * build: upgrade -dlgo version to Go 1.18.5 * eth/gasprice/feehistory: support finalized block (ethereum#25442) * consensus/ethash: remove temp files created during DAG generation (ethereum#25381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating. * cmd/devp2p/internal/ethtest: update tests for eth/67 (ethereum#25306) * node, rpc: add ReadHeaderTimeout config option (ethereum#25338) This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments. * core/types: fix typo in comment (ethereum#25359) * core: preallocate batch size in bloomIndexer (ethereum#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. * internal/ethapi: don't estimate gas if no limit provided in eth_createAccessList (ethereum#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate. * graphql: embed *Resolver instead of backend interface (ethereum#25468) This creates some infrastructure to share resources between graphql API objects. * node: remove noop path.Join (ethereum#25475) Signed-off-by: Delweng <delweng@gmail.com> * core, trie: rework trie committer (ethereum#25320) * all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test * core: use TryGetAccount to read what TryUpdateAccount has written (ethereum#25458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * cmd, core, ethdb, node: move chain freezer one folder deeper (ethereum#25487) * cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue * eth/downloader: fix log errors of queue_test.go (ethereum#25494) * core: fix uncle creation in TestFastVsFullChains (ethereum#25476) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: formatted error nit (ethereum#25499) * eth/tracers: add onlyTopCall option to callTracer (ethereum#25430) This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See ethereum#25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about. * all: cleanup the APIs for initializing genesis (ethereum#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment * core: remove unused bc ChainContext in applyTransaction * signer/rules: register clef api properly when rules are used (ethereum#25455) signer/rules: register clef api properly when rules are used, fixes ethereum#25298 * build: add static linking support (ethereum#25492) This adds support for building statically-linked executables using ci.go. Static linking is enabled by default in Docker builds, making it possible to use the geth executable in any Docker image, regardless of the Linux distribution the Dockerfile is based on. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: display name in "method/event not found" error (ethereum#25512) * internal/ethapi: rework setDefaults for tx args so fee logic is separate (ethereum#25197) Co-authored-by: bobpkr <bob.p@krustuniverse.com> * core/genesis: remove calaverasAllocData (ethereum#25516) core/genesis: calaverasAllocData no longer used * params: set ttdpassed on goerli (ethereum#25519) * params: set mainnet terminal total difficulty for the merge (ethereum#25528) * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * core, trie: flush preimages to db on blockchain close (ethereum#25533) * core, trie: flush preimages to db on database close Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * rename Close to CommitPreimages for clarity * core, trie: nitpick fixes Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core/state, trie, light: add a TryDeleteAccount method (ethereum#25531) * core/state, trie, light: Add a DeleteAccount method * review feedback * Update database.go * pr triage feedback Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: make tx journal check and open atomic (ethereum#25530) * core: reduce system call about `os` * avoid deprecated method * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * Release Geth v1.10.24 * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * params: release Geth v1.10.25 * eth/protocols/snap: fix problems due to idle-but-busy peers (ethereum#25651) * eth/protocols/snap: throttle trie heal requests when peers DoS us (ethereum#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <martin@swende.se> * trie: check childrens' existence concurrently for snap heal (ethereum#25694) * eth: fix a rare datarace on CHT challenge reply / shutdown (ethereum#25831) * eth/filters: change filter block to be by-ref (ethereum#26054) This PR changes the block field in the filter to be a pointer, to disambiguate between empty hash and no hash * rpc: handle wrong HTTP batch response length (ethereum#26064) * params: release geth v1.10.26 stable Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Harry Kalodner <harry.kalodner@gmail.com> Co-authored-by: Boqin Qin(秦伯钦) <Bobbqqin@gmail.com> Co-authored-by: Ivan Kuznetsov <me@jeiwan.ru> Co-authored-by: Jonathan Le Brun <42697488+icyfry@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: Paweł Bylica <chfast@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: lwh <lwhile521@gmail.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com> Co-authored-by: Rajaram Gaunker <zimbabao@gmail.com> Co-authored-by: henridf <henri@dubfer.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: Luozhu <70309026+LuozhuZhang@users.noreply.github.com> Co-authored-by: Gustavo Silva <GustavoRSSilva@users.noreply.github.com> Co-authored-by: Ivan Aracki <aracki.ivan@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: Kosuke Taniguchi <73885532+TaniguchiKosuke@users.noreply.github.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: willian.eth <willian@ufpa.br> Co-authored-by: zeim839 <50573884+zeim839@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Ruohui Wang <nomaru@outlook.com> Co-authored-by: Andre Patta <andre_luis@outlook.com> Co-authored-by: スパイク <1311798+spkjp@users.noreply.github.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Brion <4777457+cifer76@users.noreply.github.com> Co-authored-by: Philip Fan <fanwengang@hotmail.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: Jens <jmw.1906@gmx.de> Co-authored-by: henridf <henridf@gmail.com> Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Ha ĐANG <dvietha@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Eval EXEC <execvy@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Rithwik Babu <rithwikbabu2020@gmail.com> Co-authored-by: Henry <101552941+henry-0@users.noreply.github.com> Co-authored-by: Manoj Kumar <mnjkmr398@gmail.com> Co-authored-by: Tristan-Wilson <87238672+Tristan-Wilson@users.noreply.github.com> Co-authored-by: yong <33920876+yzhaoyu@users.noreply.github.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: ycyraum <ycyraum@fastmail.com> Co-authored-by: 0xe3b0c4 <110295932+0xe3b0c4@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: bobpkr <bob.p@krustuniverse.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Jordan Krage <jmank88@gmail.com>

eth: add missing periods on end of comments

eth: add missing periods on end of comments

52e8c2c

lightclient requested review from karalabe, holiman and rjl493456442 as code owners June 10, 2022 11:10

s1na approved these changes Jun 13, 2022

View reviewed changes

holiman approved these changes Jun 15, 2022

View reviewed changes

holiman added this to the 1.10.19 milestone Jun 15, 2022

holiman merged commit 3273ad1 into ethereum:master Jun 15, 2022

sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Jun 16, 2022

eth: add missing period at end of sentences (ethereum#25058)

ce86816

eth: add missing periods on end of comments

blakehhuynh pushed a commit to blakehhuynh/go-ethereum that referenced this pull request Oct 3, 2022

eth: add missing period at end of sentences (ethereum#25058)

3f84ad4

eth: add missing periods on end of comments

blakehhuynh pushed a commit to blakehhuynh/go-ethereum that referenced this pull request Oct 7, 2022

eth: add missing period at end of sentences (ethereum#25058)

8fa3a2a

eth: add missing periods on end of comments

blakehhuynh pushed a commit to blakehhuynh/go-ethereum that referenced this pull request Oct 7, 2022

eth: add missing period at end of sentences (ethereum#25058)

5702dff

eth: add missing periods on end of comments

cp-wjhan pushed a commit to cp-yoonjin/go-wemix that referenced this pull request Jun 14, 2023

eth: add missing period at end of sentences (ethereum#25058)

209c275

eth: add missing periods on end of comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing periods on end of comments #25058

Add missing periods on end of comments #25058

lightclient commented Jun 10, 2022

s1na left a comment

holiman left a comment

Add missing periods on end of comments #25058

Add missing periods on end of comments #25058

Conversation

lightclient commented Jun 10, 2022

s1na left a comment

Choose a reason for hiding this comment

holiman left a comment

Choose a reason for hiding this comment