Abigen redeclares field in struct in output

[Deofex]

System information

Abigen version: 1.10.17
OS & Version: OSX

Actual behaviour

ABIGen creates invalid Golang code (redeclares field in struct) :

// EventimplementationEventDataSet represents a EventDataSet event raised by the Eventimplementation contract.
type EventimplementationEventDataSet struct {
	EventData IEventImplementationEventData
	EventData IEventImplementationEventData
	Raw       types.Log // Blockchain specific contextual infos
}

Steps to reproduce the behaviour

The following (part of a bigger ) ABI can be used to reproduce this error:

[
    {
        "anonymous": false,
        "inputs": [
            {
                "components": [
                    {
                        "internalType": "string",
                        "name": "name",
                        "type": "string"
                    }
                ],
                "indexed": true,
                "internalType": "struct IEventImplementation.EventData",
                "name": "eventData",
                "type": "tuple"
            },
            {
                "components": [
                    {
                        "internalType": "string",
                        "name": "name",
                        "type": "string"
                    }
                ],
                "indexed": true,
                "internalType": "struct IEventImplementation.EventData",
                "name": "_eventData",
                "type": "tuple"
            }
        ],
        "name": "EventDataSet",
        "type": "event"
    }
]

This can't be solved with abigen --alias, because the input names are the problem while --alias is only useful for functions and events.

[rjl493456442]

This can't be solved with abigen --alias, because the input names are the problem while --alias is only useful for functions and events.

Correct. Do you want to open a PR to fix it? Btw personally I think the name conflicts can be resolved by adding the number suffix. Since it's just the auto-generated file, it's not a big deal by changing the field name slightly.

[lwhile]

@rjl493456442 I also encountered this problem and I am willing to fix it.

[MariusVanDerWijden]

resolved