core, trie: extend the state reader interface with StorageExists #30218
Conversation
rjl493456442
requested review from
lightclient,
karalabe,
holiman and
MariusVanDerWijden
as code owners
| // mustCopyTrie returns a deep-copied trie. | ||
| func mustCopyTrie(t Trie) Trie { | ||
| switch t := t.(type) { | ||
| case *trie.StateTrie: | ||
| return t.Copy() | ||
| case *trie.VerkleTrie: | ||
| return t.Copy() | ||
| default: | ||
| panic(fmt.Errorf("unknown trie type %T", t)) | ||
| } | ||
| } |
There was a problem hiding this comment.
why do you need this? would it not be simpler to just call t.Copy()?
| // StorageExists implements state.Trie, returning a flag indicating whether the | ||
| // requested storage slot is existent or not. | ||
| func (t *VerkleTrie) StorageExists(addr common.Address, key []byte) (bool, error) { | ||
| k := utils.StorageSlotKeyWithEvaluatedAddress(t.cache.Get(addr.Bytes()), key) | ||
| val, err := t.root.Get(k, t.nodeResolver) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| return len(val) != 0, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
would it not be faster to directly do t.reader.StorageExists ? because if I call Get I will jump from node to node until I find the target - whereas if they went straight to the right key, we would get this information. Since it can not be deleted, if it's found in the difflayers or the db, it exists.
| // StorageExists implements state.Trie, returning a flag indicating whether the | ||
| // requested storage slot is existent or not. | ||
| func (t *VerkleTrie) StorageExists(addr common.Address, key []byte) (bool, error) { | ||
| k := utils.StorageSlotKeyWithEvaluatedAddress(t.cache.Get(addr.Bytes()), key) | ||
| val, err := t.root.Get(k, t.nodeResolver) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| return len(val) != 0, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
would it not be faster to directly do t.reader.StorageExists ? because if I call Get I will jump from node to node until I find the target - whereas if they went straight to the right key, we would get this information. Since it can not be deleted, if it's found in the difflayers or the db, it exists.
rjl493456442
force-pushed
the
state-reader-3
branch
from
575a3be to
f54ee58
Compare
This branch is mostly for verkle experiment