-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FILL_COST on top of Gary's new state reader #12
base: state-reader-3
Are you sure you want to change the base?
Conversation
if sf.trie != nil { | ||
sf.trie.GetStorage(sf.addr, task.key) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because OpenStorageTrie
returns its self
parameter, which is nil
in that case. So the prefetcher will try to prefetch some tree that is empty. You can't simply open the main tree, because that will be a different tree, and you want the main tree to be loaded with all the values needed.
So we need to make the main tree available to the prefetcher when opening the storage tree. In the meantime, this is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fixed in ethereum#30354
575a3be
to
f54ee58
Compare
This is a rebase of my FILL_COST PR on top of ethereum#30218.
It seems to cause a crash whose root cause must be in the way I try to read the node: