Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/txpool: terminate subpool reset goroutine if pool was closed #31030

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Jan 14, 2025

if the pool terminates before resetDone can be read, then the go-routine will hang.

core/txpool/txpool.go Outdated Show resolved Hide resolved
core/txpool/txpool.go Outdated Show resolved Hide resolved
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjl493456442 rjl493456442 self-assigned this Jan 21, 2025
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@rjl493456442 rjl493456442 added this to the 1.14.13 milestone Jan 21, 2025
@rjl493456442 rjl493456442 merged commit e25cedf into ethereum:master Jan 21, 2025
3 checks passed
@fjl fjl modified the milestones: 1.14.13, 1.15.0 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants