Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/txpool: terminate subpool reset goroutine if pool was closed #31030

Merged
merged 2 commits into from
Jan 21, 2025
+4 −1
Merged

core/txpool: terminate subpool reset goroutine if pool was closed #31030

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c10ab5c
core/txpool: terminate subpool reset goroutine if pool was closed
jwasinger Jan 14, 2025
5d10b56
Update core/txpool/txpool.go
jwasinger Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/txpool/txpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,12 @@ func (p *TxPool) loop(head *types.Header, chain BlockChain) {
for _, subpool := range p.subpools {
subpool.Reset(oldHead, newHead)
}
resetDone <- newHead
select {
case resetDone <- newHead:
break
jwasinger marked this conversation as resolved.
Show resolved Hide resolved
case <-p.term:
return
}
jwasinger marked this conversation as resolved.
Show resolved Hide resolved
jwasinger marked this conversation as resolved.
Show resolved Hide resolved
}(oldHead, newHead)

// If the reset operation was explicitly requested, consider it
Expand Down