core/tracing: stringer for gas and nonce change reasons #31234
+91
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the same pattern as for `tracing.BalanceChangeReason`.
|
While you're at it can you add nonce change reason too? :) |
fjl
reviewed
Feb 21, 2025
core/tracing/hooks.go
Outdated
| @@ -282,6 +282,8 @@ const ( | |||
| // once per transaction, while those that start with `GasChangeCall` are emitted on a call basis. | |||
| type GasChangeReason byte | |||
|
|
|||
| //go:generate go run golang.org/x/tools/cmd/stringer -type=GasChangeReason -output gen_gas_change_reason_stringer.go | |||
There was a problem hiding this comment.
Consider using -trimprefix GasChange here. I think it will improve the output.
There was a problem hiding this comment.
Should I apply to all others too (NonceChange & BalanceChange)?
Sure thing @s1na |
|
I've applied |
|
Hello |
s1na
changed the title
tracing.GasChangeReason enum
s1na
changed the title
|
Note: this PR will change the string output for balance change reasons. But nobody should be using that for their logic code instead of the enum. I really hope nobody is actually doing that. This is giving me second thought about exposing a string version tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the same pattern as for
tracing.BalanceChangeReason.