Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracing: stringer for gas and nonce change reasons #31234

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+91 −6
Open

core/tracing: stringer for gas and nonce change reasons #31234

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9beca6c
Added generated stringer for `tracing.GasChangeReason` enum
maoueh Feb 21, 2025
29d57c1
Added `-trimprefix` and `NonceChangeReason` stringer too
maoueh Feb 21, 2025
755943f
Fixed tests
maoueh Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions core/tracing/gen_gas_change_reason_stringer.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions core/tracing/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ const (
// once per transaction, while those that start with `GasChangeCall` are emitted on a call basis.
type GasChangeReason byte

//go:generate go run golang.org/x/tools/cmd/stringer -type=GasChangeReason -output gen_gas_change_reason_stringer.go
Copy link
Contributor

@fjl fjl Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using -trimprefix GasChange here. I think it will improve the output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I apply to all others too (NonceChange & BalanceChange)?


const (
GasChangeUnspecified GasChangeReason = 0

Expand Down