Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Commit

Permalink
remove 'update-nodes' hook from 'npm install'; add '--platform' option (
Browse files Browse the repository at this point in the history
#988)

* split 'update-nodes' from 'npm install'; add '--platform' option

* add 'gulp update-nodes' to .travis.yml

* fix travis

* fix .travis.yml electron version

* remove generic electron download
  • Loading branch information
luclu authored and Alex Van de Sande committed Jul 24, 2016
1 parent 074bbff commit 92b0356
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ before_script:
- "sh -e /etc/init.d/xvfb start"
- "sleep 3" # give xvfb some time to start
- "curl https://install.meteor.com/ | sh"
- "npm install -g electron-prebuilt@1.2.2"
- "npm install -g meteor-build-client"
- "gulp update-nodes --platform linux"

script:
- "npm run ci"
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ This will generate the binaries inside the `dist_mist` or `dist_wallet` folder.

Additional you can only build the windows, linux or mac binary by using the `platform` option:

$ gulp update-nodes --platform darwin

// And
$ gulp mist --platform darwin

// Or
Expand Down
7 changes: 4 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ gulp.task('downloadNodes', ['clean:nodes'], function(done) {
// ? path +'/'+ filenameUppercase +'.app/Contents/Frameworks/node'
//: path +'/resources/node';


// donwload nodes
streams.push(download(nodeUrl)
.pipe(gulp.dest('./nodes/geth/')));
if (os.indexOf(options.platform) !== -1)
streams.push(download(nodeUrl)
.pipe(gulp.dest('./nodes/geth/')));

});

Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
"url": "https://github.com/ethereum/mist.git"
},
"scripts": {
"ci": "gulp --platform=linux",
"postinstall": "gulp update-nodes"
"ci": "gulp --platform=linux"
},
"main": "main.js",
"dependencies": {
Expand Down

0 comments on commit 92b0356

Please sign in to comment.