Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

remove 'update-nodes' hook from 'npm install'; add '--platform' option #988

Merged
merged 5 commits into from
Jul 24, 2016
Merged

remove 'update-nodes' hook from 'npm install'; add '--platform' option #988

merged 5 commits into from
Jul 24, 2016

Conversation

luclu
Copy link
Contributor

@luclu luclu commented Jul 18, 2016

fixes #987

@luclu
Copy link
Contributor Author

luclu commented Jul 18, 2016

@hiddentao do we need npm install -g electron-prebuilt@1.2.2 .travis.yml#L18 as this seems to get pulled by electron-packager while bundling.

@luclu luclu mentioned this pull request Jul 18, 2016
Closed
@hiddentao hiddentao mentioned this pull request Jul 18, 2016
Closed
@hiddentao
Copy link
Contributor

Yeah we might not need that. I was just copying over our README.md instructions.

@alexvandesande alexvandesande merged commit 92b0356 into ethereum:develop Jul 24, 2016
@luclu luclu mentioned this pull request Aug 3, 2016
Closed
@luclu luclu deleted the split-node-download branch October 8, 2016 11:04
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove postinstall hook from package.json
4 participants
@luclu @hiddentao @evertonfraga @alexvandesande