Use new network simulator library in tests #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tangentially related: #1100 |
cburgdorf
reviewed
Jul 26, 2018
setup.py
Outdated
| @@ -50,7 +50,7 @@ | |||
| "pytest-xdist==1.18.1", | |||
| "pytest-watch>=4.1.0,<5", | |||
| # only needed for p2p | |||
| "pytest-asyncio-network-simulator==0.1.0a1", | |||
| "pytest-asyncio-network-simulator==0.1.0a1;python_version>='3.6'", | |||
There was a problem hiding this comment.
Does this syntax mean: Only install this if we are in a python 3.6 environment?
There was a problem hiding this comment.
Yes, fancy-pants setup tools wizardy. Slight correction: it means "only if we're in >= Python 3.6"
carver
approved these changes
Jul 27, 2018
tests/p2p/conftest.py
Outdated
| @@ -30,3 +33,10 @@ def p2p_logger(): | |||
|
|
|||
| return logger | |||
| """ | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
There was a problem hiding this comment.
Probably an autouse=True here?
There was a problem hiding this comment.
I find it hilarious that I forgot that. Think I'll add a small test that verifies that asyncio is indeed patched.
pipermerriam
force-pushed
the
piper/use-network-simulator-in-p2p-tests
branch
from
99cecc1 to
b613297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some of our
p2ptests use real networking.How was it fixed?
Change to use the new library
pytest-asyncio-network-simulatorwhich mocks out the networking.Cute Animal Picture