convert to use CancelToken from libary #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsalgado if you have any feedback I'll clean it up post merge. |
gsalgado
reviewed
Jul 30, 2018
| @@ -42,7 +42,8 @@ | |||
|
|
|||
| from eth_hash.auto import keccak | |||
|
|
|||
| from p2p.cancel_token import CancelToken | |||
| from cancel_token import CancelToken | |||
|
|
|||
| from p2p.exceptions import NoEligibleNodes, OperationCancelled | |||
There was a problem hiding this comment.
We need to get rid of p2p.exceptions.OperationCancelled and use the one from cancel_token instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
CancelTokenhas been extracted into a separate libraryasyncio-cancel-token.How was it fixed?
Convert all code to use the new library version.
Cute Animal Picture