Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the duplicate functions #1441

Closed
wants to merge 19 commits into from
Closed

Removed the duplicate functions #1441

wants to merge 19 commits into from

Commits on Oct 26, 2018

  1. I removed the duplicate functions from /fixtures/normalization.py mai…

    …nly except the
    
    functions under the header "Fixture Normalizers" as I felt those belonged and as
    such removed them from /_utils/normalization.py instead.
    isaacelee committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    f3dafb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Make accidentially private methods public

    These methods were named so that they appeared
    private by convention. This convention causes
    trouble in the documentation where these methods
    are righfully dropped. Since these methods aren't
    really private in reality (they need to be overwritten
    in subclasses), they were renamed, migrating their
    naming from `_*` to `do_*`.
    cburgdorf committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    58e4eaf View commit details
    Browse the repository at this point in the history
  2. Plugins: replace running bool with PluginStatus enum

    This enables the plugin to read the status of the
    four formal states a plugin can be in. Previously
    even though the four states existed implicitly,
    it could only be differentiated between the
    STARTED/STOPPED state based on the `running`
    bool.
    
    This change also has the nice benefit that we
    can make stronger assumptions about the status
    inside `start()` and raise an exception if
    `start()` was called on a plugin that isn't in
    the correct status to call `start()`
    cburgdorf committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    99f44ec View commit details
    Browse the repository at this point in the history
  3. Add rudimentary plugin guide

    Relates to #1103
    cburgdorf committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    455678e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. merge --nodekey and --nodekey-path

    jvmaia authored and cburgdorf committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    2a65ca4 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Configuration menu
    Copy the full SHA
    150808f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf4a24c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abea333 View commit details
    Browse the repository at this point in the history
  4. Get rid of mypy ignores

    cburgdorf committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    dc842c1 View commit details
    Browse the repository at this point in the history
  5. Correct type hints

    cburgdorf committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    7d0f188 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Fixed imports

    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    c0de429 View commit details
    Browse the repository at this point in the history
  2. I removed the duplicate functions from /fixtures/normalization.py mai…

    …nly except the
    
    functions under the header "Fixture Normalizers" as I felt those belonged and as
    such removed them from /_utils/normalization.py instead.
    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    5f8270a View commit details
    Browse the repository at this point in the history
  3. Fixed imports

    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    a116bcb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0f109b3 View commit details
    Browse the repository at this point in the history
  5. I removed the duplicate functions from /fixtures/normalization.py mai…

    …nly except the
    
    functions under the header "Fixture Normalizers" as I felt those belonged and as
    such removed them from /_utils/normalization.py instead.
    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    e3e628a View commit details
    Browse the repository at this point in the history
  6. Fixed imports

    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    294a8b5 View commit details
    Browse the repository at this point in the history
  7. Added blank line

    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    a0acaf9 View commit details
    Browse the repository at this point in the history
  8. Added blank line

    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    88b2001 View commit details
    Browse the repository at this point in the history
  9. Fixed imports again

    isaacelee committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    97b2639 View commit details
    Browse the repository at this point in the history