Removed the duplicate functions #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly except the functions under the header "Fixture Normalizers" as I felt those belonged and as such removed them from /_utils/normalization.py instead.
|
@isaacelee lots of failed tests. Looks like you need to spend some time updating the imports for some of these to import from the right location. |
These methods were named so that they appeared private by convention. This convention causes trouble in the documentation where these methods are righfully dropped. Since these methods aren't really private in reality (they need to be overwritten in subclasses), they were renamed, migrating their naming from `_*` to `do_*`.
This enables the plugin to read the status of the four formal states a plugin can be in. Previously even though the four states existed implicitly, it could only be differentiated between the STARTED/STOPPED state based on the `running` bool. This change also has the nice benefit that we can make stronger assumptions about the status inside `start()` and raise an exception if `start()` was called on a plugin that isn't in the correct status to call `start()`
Relates to #1103
…nly except the functions under the header "Fixture Normalizers" as I felt those belonged and as such removed them from /_utils/normalization.py instead.
…elee/py-evm into remove-duplicate-functions
…nly except the functions under the header "Fixture Normalizers" as I felt those belonged and as such removed them from /_utils/normalization.py instead.
|
Not sure if I've made a complete mess of things trying to update my fork with the master branch, let me know if I need to create a new pull request and I can try and refork and do it right the first time. Hopefully this sorts everything out and sorry about the delay, midterm exams. |
|
This PR will need to be fixed as it's history isn't something we can merge. I'd recommend going and reading up on how to do a |
|
Apart from the PR not getting the rebase it needs, this was fixed in #1486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the duplicate functions from /fixtures/normalization.py mainly except the
functions under the header "Fixture Normalizers" as I felt those belonged and as
such removed them from /_utils/normalization.py instead.
Meant to fix #1407