Removing eth.tools.fixtures.normalization
#1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaksmono
force-pushed
the
py-evm-1407
branch
4 times, most recently
from
c9a016c
to
aa774d2
Compare
…s are duplicates of `eth.tools._utils.normalization`
glaksmono
force-pushed
the
py-evm-1407
branch
from
aa774d2
to
d5ed84c
Compare
cburgdorf
approved these changes
Nov 20, 2018
|
Looks good! 👍 Merged! Thanks for contributing again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There are duplicates of some of the functions in:
eth.tools._utils.normalizationeth.tools.fixtures.normalizationIssue Reference: #1407, #1396 (review)
How was it fixed?
Noticed that actually all of the methods in
eth.tools.fixtures.normalizationare duplicated ineth.tools._utils.normalization, so I decided to just useeth.tools._utils.normalizationas the de-facto implementation, removingeth.tools.fixtures.normalizationaltogether.Cute Animal Picture