Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: use CancunReceiptBuilder in CancunBlock #2166

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 4, 2024

What was wrong?

Having plugged web3.py (via PR ethereum/web3.py#3332) through eth-tester (via ethereum/eth-tester#285), these seem to be that last few changes to fully support Cancun across the stack.

How was it fixed?

  • We are incorrectly not using the CancunReceiptBuilder for CancunBlock

Todo:

Cute Animal Picture

Screenshot 2024-04-04 at 15 40 32

@fselmo fselmo marked this pull request as ready for review April 4, 2024 21:40
@fselmo fselmo requested review from kclowes, pacrob and reedsa April 4, 2024 21:57
Copy link
Collaborator

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 025caf5 into ethereum:main Apr 4, 2024
46 checks passed
@fselmo fselmo deleted the bugfix-cancun-receipts branch April 4, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants