Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EthereumTesterProvider to support cancun #3332

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 4, 2024

What was wrong?

We need Cancun support for EthereumTesterProvider.


Note: These changes will need both ethereum/eth-tester#285 and ethereum/py-evm#2166 to be merged and released.

How was it fixed?

Todo:

Cute Animal Picture

Screenshot 2024-04-04 at 15 57 55

@fselmo fselmo changed the title Update eth tester to support cancun Update EthereumTesterProvider to support cancun Apr 4, 2024
@fselmo fselmo force-pushed the update-eth-tester-to-support-cancun branch 2 times, most recently from b0706ea to 035cac7 Compare April 10, 2024 17:37
@fselmo fselmo force-pushed the update-eth-tester-to-support-cancun branch from cae0458 to 46c5aa9 Compare April 10, 2024 18:01
- Geth still doesn't have a release out where their dev mode supports Cancun.
  This gets us a blob / Cancun test for EthereumTesterProvider within the core
  test suite while we can't yet add one to the integration test suite.
@fselmo fselmo marked this pull request as ready for review April 10, 2024 22:15
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit a89e313 into ethereum:main Apr 11, 2024
81 checks passed
@fselmo fselmo deleted the update-eth-tester-to-support-cancun branch April 11, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants