Local output streams in CommandLineParser #11520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
command-line-parser
branch
from
06297f3 to
fcab7e0
Compare
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
from
301e0ae to
4b87f33
Compare
cameel
force-pushed
the
command-line-parser
branch
from
fcab7e0 to
3f499a6
Compare
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
from
4b87f33 to
2870b3c
Compare
cameel
force-pushed
the
command-line-parser
branch
4 times, most recently
from
2cf6e62 to
924430b
Compare
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
2 times, most recently
from
19c84ee to
1b92997
Compare
6 tasks
cameel
force-pushed
the
command-line-parser
branch
2 times, most recently
from
dab3783 to
2aa689f
Compare
This was referenced Jun 28, 2021
cameel
force-pushed
the
command-line-parser
branch
from
2aa689f to
e22b368
Compare
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
from
1b92997 to
7a1b6fc
Compare
cameel
force-pushed
the
command-line-parser
branch
from
e22b368 to
2827c71
Compare
Merged
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
3 times, most recently
from
3039bc3 to
efee406
Compare
cameel
force-pushed
the
command-line-parser
branch
from
82198a0 to
7200fda
Compare
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
from
efee406 to
2f7a8fa
Compare
cameel
force-pushed
the
command-line-parser
branch
2 times, most recently
from
50e1b7a to
de7881c
Compare
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
from
2f7a8fa to
ceed75e
Compare
cameel
force-pushed
the
command-line-parser
branch
2 times, most recently
from
61e994b to
ef7abd2
Compare
- This removes the global variable and prevents stderr/stdout from being printed in tests
cameel
force-pushed
the
local-streams-in-command-line-parser
branch
from
ceed75e to
baced5d
Compare
|
#11518 has been merged so this PR is now reviewable. |
chriseth
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11518. In draft mode until that PR gets merged.Merged.Now that we have tests for the part of
CommandLineInterfacethat I extracted intoCommandLineParserin #11518, we're getting messages printed during tests because they get written directly tocerr/cout. This PR changesCommandLineParserso that it receives streams as constructor parameters. In testsstringstreamsare now used which also lets us compare the content of these streams in tests and see it test output if such a check fails.