Make CommonIO testable #11589
Merged
Make CommonIO testable #11589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Jun 28, 2021
cameel
force-pushed
the
testable-common-io
branch
2 times, most recently
from
6f44eac to
2c67a36
Compare
leonardoalt
previously approved these changes
Jul 2, 2021
|
Needs rebase though |
cameel
force-pushed
the
testable-common-io
branch
from
2c67a36 to
a72857d
Compare
|
Right. Rebased. |
leonardoalt
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially standard input reading so that we can add a test in #11584.
Note: This PR contains bits from #11579 and #11520 to avoid creating more dependencies between PRs. As it is now they can all be reviewed and merged independently and whichever of these PRs goes in first, the duplicated bits will disappear from the others during the rebase.